Skip to content

[$10] Deleting Software while editing, showing "Edit software to your list" #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Nov 28, 2021 · 15 comments

Comments

@LieutenantRoger
Copy link
Collaborator

Steps:

  1. Open the Edit Profile
  2. Click Tools -> Software
  3. Enter all details and click _dd button
  4. Click Edit
  5. Click Delete button and delete the entries
  6. Observe the _dit software to your list button

Expected Result: It should clear input

Actual Result: It cannot clear

Environment: Device: Laptop OS: MacOS Browser: Chrome

https://monosnap.com/file/sF6NJXeoF9VQ6HErJu3wV3euIhiKS1

@LieutenantRoger LieutenantRoger added Functional P3 Normal (resolved within 7 days) Valid labels Nov 28, 2021
@LieutenantRoger
Copy link
Collaborator Author

can't reproduce

@LieutenantRoger LieutenantRoger changed the title Deleting Service Providers while editing, showing "Edit software to your list" [$10] Deleting Service Providers while editing, showing "Edit software to your list" Nov 30, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/370fe075-5406-4d83-b683-bd2060ec8055 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@gets0ul
Copy link
Collaborator

gets0ul commented Nov 30, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@gets0ul ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/370fe075-5406-4d83-b683-bd2060ec8055 has been assigned to gets0ul.

This is an automated message for lieutenantroger via Topcoder X

gets0ul added a commit to gets0ul/community-app that referenced this issue Nov 30, 2021
@gets0ul
Copy link
Collaborator

gets0ul commented Nov 30, 2021

@bug-bash-helper #5893 is ready for review

@bug-bash-hunt-helper
Copy link

@gets0ul ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@LieutenantRoger
Copy link
Collaborator Author

vv.mp4

@gets0ul THe fix seems not working, please see the recording.

@LieutenantRoger
Copy link
Collaborator Author

We fixed similar issue for `hobby' under profile tab, please refer to the similar implementation there.

@gets0ul
Copy link
Collaborator

gets0ul commented Dec 1, 2021

@LieutenantRoger
It is actually already fixed. It is for 'Software' tab per issue description.

This issue's title is little bit confusing.
The issue title begins with "Service Providers" but then it followed by "showing "Edit software to your list"" which can only be found in "Software" tab.

Both the issue description and posted video in https://monosnap.com/file/sF6NJXeoF9VQ6HErJu3wV3euIhiKS1 are all for fixing issue in "Software" tab.

@LieutenantRoger LieutenantRoger changed the title [$10] Deleting Service Providers while editing, showing "Edit software to your list" [$10] Deleting Software while editing, showing "Edit software to your list" Dec 1, 2021
LieutenantRoger pushed a commit that referenced this issue Dec 1, 2021
* fix: issue #5878

* fix: lint tab error
@LieutenantRoger
Copy link
Collaborator Author

Thanks for clarify, I updated this ticket.

@codejamtc
Copy link
Collaborator

Fixed on Test https://test-community-app.topcoder-dev.com/settings/tools#software 🆗

bandicam.2021-12-02.09-24-57-781.mp4

@codejamtc codejamtc added this to the v1.14.5 milestone Dec 2, 2021
@coderhacker
Copy link

@coderhacker coderhacker added QA Pass in Staging Staging Env Prod Env Environment QA Pass in PROD Passed verification on Production labels Dec 7, 2021
@coderhacker
Copy link

This is passed on production:

5878.mp4

@LieutenantRoger
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/370fe075-5406-4d83-b683-bd2060ec8055
Payments Complete
Winner: gets0ul
Copilot: lieutenantroger
Challenge 370fe075-5406-4d83-b683-bd2060ec8055 has been paid and closed.

This is an automated message for lieutenantroger via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants