Skip to content

[$5] Language gets re-ordered after saving #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Nov 28, 2021 · 11 comments
Closed

[$5] Language gets re-ordered after saving #5874

LieutenantRoger opened this issue Nov 28, 2021 · 11 comments

Comments

@LieutenantRoger
Copy link
Collaborator

Steps

Go to https://www.topcoder.com/settings/profile#language
Add Afar as language to the list
Add Abkhazian as language to the list
Add Avestan as language to the list
Click Edit for Avestan and click "Edit language to your list"
Click Edit for Abkhazian and click "Edit language to your list", observe list behavior
Do the same for Afar and observe list behavior

Expected Result

Nothing should happen to the list order after editing

Actual Result

The edited item in the list moves up in the order after saving

Screenshot/Screencast

language_order

Environment

  • Device: Desktop
  • OS: Windows 10 Pro version 20H2 build 19042.1288
  • Browser:
    • Chrome 95.0.4638.54
    • Firefox 93.0
    • Microsoft Edge 95.0.1020.30
@LieutenantRoger LieutenantRoger added Functional P3 Normal (resolved within 7 days) Valid labels Nov 28, 2021
@LieutenantRoger
Copy link
Collaborator Author

LieutenantRoger commented Nov 30, 2021

It seems when we pass the languages data to the API, the order is reversed. Please maintain the order when calling the api to update the language.

@LieutenantRoger LieutenantRoger changed the title Language gets re-ordered after saving [$5] Language gets re-ordered after saving Nov 30, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/a3aaab95-fe16-4e8e-bdea-584e7a1cc7e7 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@gets0ul
Copy link
Collaborator

gets0ul commented Dec 1, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@gets0ul ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/a3aaab95-fe16-4e8e-bdea-584e7a1cc7e7 has been assigned to gets0ul.

This is an automated message for lieutenantroger via Topcoder X

gets0ul added a commit to gets0ul/community-app that referenced this issue Dec 1, 2021
@gets0ul
Copy link
Collaborator

gets0ul commented Dec 1, 2021

@bug-bash-helper #5896 is ready for review

@bug-bash-hunt-helper
Copy link

@gets0ul ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@codejamtc
Copy link
Collaborator

Fixed in Test https://test-community-app.topcoder-dev.com/settings/profile#language 🆗

bandicam.2021-12-02.09-32-36-619.mp4

@coderhacker
Copy link

passed on stage

5874_staging.pass.mp4

@coderhacker
Copy link

This is passed on to production

5874.mp4

@LieutenantRoger
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/a3aaab95-fe16-4e8e-bdea-584e7a1cc7e7
Payments Complete
Winner: gets0ul
Copilot: lieutenantroger
Challenge a3aaab95-fe16-4e8e-bdea-584e7a1cc7e7 has been paid and closed.

This is an automated message for lieutenantroger via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants