Skip to content

[$25] Able to edit and save duplicate Devices #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LieutenantRoger opened this issue Nov 12, 2021 · 25 comments
Closed

[$25] Able to edit and save duplicate Devices #5802

LieutenantRoger opened this issue Nov 12, 2021 · 25 comments
Assignees
@yoution
Labels
BE CF FE Functional P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid Valid
Milestone
v1.14.3

Comments

@LieutenantRoger
Copy link
Collaborator

Able to edit and save duplicate Devices

Steps to Reproduce

  1. Go to https://www.topcoder.com/settings/profile#work
  2. Devices
  3. Add device
  4. Try to add same device - error lists out as shown
  5. Add another device with different parameters
  6. Edit new device and place same as first device details

Actual Result(s)

Effectively duplicated devices
image

image

Expected Result(s)

Not to be added.

Environment Details

Device(s):
Laptop

Operating System:
Windows 10

Browser:
Google Chrome : 95.0.4638.54 (Official Build) (64-bit)
@LieutenantRoger LieutenantRoger added Functional P2 Important (resolve within 3 days) Valid BE FE labels Nov 12, 2021
@LieutenantRoger
Copy link
Collaborator Author

Request URL: https://api.topcoder.com/v3/members/CustomerUser/traits

@LieutenantRoger LieutenantRoger changed the title Able to edit and save duplicate Devices [$25] Able to edit and save duplicate Devices Nov 16, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/9e454cce-392c-43e6-a99e-c881924fcf1c has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@LieutenantRoger
Copy link
Collaborator Author

The API won't validate this, so let's see if we have frontend solution to avoid this

@yoution
Copy link
Contributor

yoution commented Nov 17, 2021

@bug-bash-helper assign

@bug-bash-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/9e454cce-392c-43e6-a99e-c881924fcf1c has been assigned to yoution.

This is an automated message for lieutenantroger via Topcoder X

yoution added a commit to yoution/community-app that referenced this issue Nov 17, 2021
@yoution
fix: issue topcoder-platform#5802
6312317
@yoution
Copy link
Contributor

yoution commented Nov 17, 2021

@bug-bash-helper #5812 is ready for review

@bug-bash-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

1 similar comment
@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

yoution added a commit to yoution/community-app that referenced this issue Nov 17, 2021
@yoution
fix: issue topcoder-platform#5802
c70b4eb
LieutenantRoger pushed a commit that referenced this issue Nov 17, 2021
@yoution
fix: issue #5802 (#5812)
665a385
@bug-bash-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

1 similar comment
@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@yoution
Copy link
Contributor

yoution commented Nov 19, 2021

@LieutenantRoger please review

LieutenantRoger pushed a commit that referenced this issue Nov 19, 2021
@yoution
fix: issue #5802 (#5823)
aa9e173
@codejamtc
Copy link
Collaborator

Fixed 🆗

bandicam.2021-11-19.22-05-12-273.mp4

LieutenantRoger added a commit that referenced this issue Nov 19, 2021
@LieutenantRoger @fikzzzy
@yoution @shivam-51
[Bug Bash] Fixes I (#5826)
282b89c 
* Enable Clear Date Input (#5809)

* Validate Non Valid Input Characters (#5810)

* ci:deploying

* fix: issue #5807 (#5811)

* fix: issue #5802 (#5812)

* fix: issue #5796 (#5813)

* fix: #5798 (#5814)

* fix:5798-2

* fix: test

* fix: issue #5800 (#5816)

* fix: issue #5786 (#5815)

* fix: issue #5802 (#5823)

* deploying ca-branch

* revert ci

Co-authored-by: M Fikri A <[email protected]>
Co-authored-by: yoution <[email protected]>
Co-authored-by: Shivam Kumar Singh <[email protected]>
@codejamtc codejamtc added this to the v1.14.3 milestone Nov 19, 2021
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger , we cant use the model+manufacturer as unique key check, because for desktops and laptops, we only have the "any" options that the user can use to add multiple devices. cc @codejamtc
For example, user should be able to add multiple desktops with different Operating Systems.

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed QA Pass in Dev labels Nov 22, 2021
This was referenced Nov 22, 2021
Merged
Merged
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger , looks good now.

@SathyaJayabal SathyaJayabal added QA Pass in Staging and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Nov 22, 2021
@coderhacker
Copy link

This is pass on production

image

@LieutenantRoger
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/9e454cce-392c-43e6-a99e-c881924fcf1c
Payments Complete
Winner: yoution
Copilot: lieutenantroger
Challenge 9e454cce-392c-43e6-a99e-c881924fcf1c has been paid and closed.

This is an automated message for lieutenantroger via Topcoder X

@coderhacker coderhacker added QA Pass in PROD Passed verification on Production and removed tcx_Paid labels Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoution yoution

Labels
BE CF FE Functional P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid Valid
Projects
None yet
Milestone
v1.14.3
Development

No branches or pull requests
5 participants
@LieutenantRoger @yoution @codejamtc @SathyaJayabal @coderhacker