Skip to content

[$10] Can upload any type of file to Profile picture, no file validation #5795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Nov 12, 2021 · 25 comments
Closed

Comments

@LieutenantRoger
Copy link
Collaborator

Summary
Can upload any type of file to Profile picture

Issue Type
Functional

Steps

  1. Open https://www.topcoder.com/settings/profile
  2. Click upload a new avatar and select All Files from File Type and select a .zip file

Actual result: Can upload any type of file to Profile picture, no file validation

Expected results: Should have file validation

Snapshots/Recording
Topcoder_-_Google_Chrome_2021-10-22_20-40-24_Trim

*Device/Broswer:
Browser: Chrome https://prnt.sc/1vb5r8v
Device: Windows 10 https://prnt.sc/1vb5v0a

@LieutenantRoger
Copy link
Collaborator Author

Let's restrict the frontend can only upload normal pictures such as: 'jpg, png, jpeg' files

@LieutenantRoger LieutenantRoger changed the title Can upload any type of file to Profile picture, no file validation [$10] Can upload any type of file to Profile picture, no file validation Nov 20, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/bdb20225-cb77-4665-b0b3-2c9a8d8cbb9a has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@FilipRazek
Copy link

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@FilipRazek ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@FilipRazek
Copy link

@bug-bash-helper {link to pull request} is ready for review

@bug-bash-hunt-helper
Copy link

@FilipRazek ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@LieutenantRoger
Copy link
Collaborator Author

Z.mp4
  1. The fix doesn't work, please see the recording on my local.
  2. Please create your working branch based on ca-profile-bug-bash branch, you seems creating the branch based on 'develop' branch, also your PR is targeting the develop branch , which are not correct

@shivam-51
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@shivam-51 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@shivam-51
Copy link
Contributor

Is this issue not open for pickup anymore?

@shivam-51
Copy link
Contributor

@bug-bash-helper #5837 is ready for review

@bug-bash-hunt-helper
Copy link

@shivam-51 ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@codejamtc
Copy link
Collaborator

@shivam-51 @LieutenantRoger Not sure this is fixed

bandicam.2021-11-27.06-59-29-986.mp4

@LieutenantRoger
Copy link
Collaborator Author

Oh @codejamtc please use test env for testing. I didn’t deploy it to dev to just make sure dev env are clean. Here you can checkout which env has deployed which branch. Our fix branch is on test env

https://community-app-dev-dashboard.herokuapp.com/#/dashboard

@codejamtc
Copy link
Collaborator

Fixed 🆗 https://test-community-app.topcoder-dev.com/settings/profile#basic-info

bandicam.2021-11-27.09-40-07-732.mp4

@codejamtc
Copy link
Collaborator

Checked in Dev 🆗

Invalid Files

bandicam.2021-11-29.10-25-51-814.mp4

Valid Files:

bandicam.2021-11-29.10-26-17-994.mp4

@codejamtc
Copy link
Collaborator

Checked in Staging 🆗

bandicam.2021-11-29.19-22-19-689.mp4

@shivam-51
Copy link
Contributor

@bug-bash-helper unassign

@bug-bash-hunt-helper
Copy link

@shivam-51 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

@LieutenantRoger
Copy link
Collaborator Author

[400]: Failed to remove resource from the challenge. Detail: Cannot delete resources of a completed challenge!

This is an automated message for lieutenantroger via Topcoder X

@codejamtc codejamtc added the QA Pass in PROD Passed verification on Production label Nov 30, 2021
@codejamtc
Copy link
Collaborator

codejamtc commented Nov 30, 2021

Verified in Prod 🆗

bandicam.2021-11-30.21-51-22-327.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants