Skip to content

Update login modal on gig details page #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Mar 30, 2021 · 6 comments
Closed

Update login modal on gig details page #5448

kkartunov opened this issue Mar 30, 2021 · 6 comments
Assignees
@kkartunov
Labels
Gig Work P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production
Milestone
v1.8.5

Comments

@kkartunov
Copy link
Collaborator

When clicking "APPLY TO THIS JOB" this modal pops:
image

We want to update it to match: https://marvelapp.com/prototype/f0i4ece/screen/78025759
@kkartunov kkartunov self-assigned this Mar 30, 2021
@kkartunov kkartunov added the P2 Important (resolve within 3 days) label Mar 30, 2021
kkartunov added a commit that referenced this issue Apr 5, 2021
@kkartunov
Implement #5448
6742a5f
@kkartunov kkartunov added this to the v1.8.6 milestone Apr 5, 2021
@sandhiyakavi
Copy link
Collaborator

@kkartunov In Design (https://marvelapp.com/prototype/f0i4ece/screen/78025759) the heading is in single line but the pop up is going to second line in Test Env.

image
image

@kkartunov
Copy link
Collaborator Author

@sandhiyakavi what is the screen resolution used?

@kkartunov
Copy link
Collaborator Author

The design referred is for 1440px and above. It is fine to go to more lines for screens smaller than 1440px. We can processed with that...

@sandhiyakavi
Copy link
Collaborator

@kkartunov Yes, my screen resolution is lower than 1440px. I will mark the issue as pass.

@luizrrodrigues luizrrodrigues modified the milestones: v1.8.6, v1.8.5 Apr 8, 2021
@kkartunov kkartunov mentioned this issue Apr 8, 2021
Merged
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop branch)
Screenshot 2021-04-09 at 11 52 54 AM

@sandhiyakavi
Copy link
Collaborator

Verified on Prod Env.

image

@sandhiyakavi sandhiyakavi added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Gig Work P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production
Projects
None yet
Milestone
v1.8.5
Development

No branches or pull requests
4 participants
@kkartunov @luizrrodrigues @sandhiyakavi @SathyaJayabal