Skip to content

[$50] Topgear Profiles Not Loading #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajefts opened this issue Jan 18, 2021 · 48 comments
Closed

[$50] Topgear Profiles Not Loading #5308

ajefts opened this issue Jan 18, 2021 · 48 comments
Labels
Bug Bash Issues going in next bug bash Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned topgear
Milestone

Comments

@ajefts
Copy link
Member

ajefts commented Jan 18, 2021

Describe the bug
When loading a profile via the Topgear site, it's attempting to filter it to groups that pertain to topgear only. In doing so, we're now hitting URI limits in the API requests it's trying to make. This is because it's trying to include all the groups the member is in as a filter in the request.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://topgear.topcoder.com/members/narayanana/
  2. Check the API calls in the console
  3. Notice the groupIds param and the # of groups it's trying to filter on.

Expected behavior
Normal profile page should load.

Screenshots

image

@ajefts
Copy link
Member Author

ajefts commented Jan 18, 2021

fyi @Oanh-and-only-Oanh

Not a P0, but probably a 1 or maybe 2.

@SathyaJayabal SathyaJayabal added the P1 Urgent (resolve within 24 hours) label Feb 4, 2021
@ajefts
Copy link
Member Author

ajefts commented Mar 8, 2021

@Oanh-and-only-Oanh just checking if there is an eta on this one? Thanks.

@luizrrodrigues luizrrodrigues added this to the v1.8.3 milestone Mar 11, 2021
@luizrrodrigues
Copy link
Collaborator

@luizrrodrigues luizrrodrigues changed the title Topgear Profiles Not Loading [$50] Topgear Profiles Not Loading Mar 16, 2021
@luizrrodrigues luizrrodrigues added tcx_OpenForPickup Bug Bash Issues going in next bug bash labels Mar 16, 2021
@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/e96d0565-5c98-425e-bfe5-dfe6b8d2451d has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@ghost ghost self-assigned this Mar 16, 2021
@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/e96d0565-5c98-425e-bfe5-dfe6b8d2451d has been assigned to mfikria.

This is an automated message for luizrrodrigues via Topcoder X

@ghost ghost removed their assignment Mar 17, 2021
@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/e96d0565-5c98-425e-bfe5-dfe6b8d2451d mfikria has been unassigned.

This is an automated message for luizrrodrigues via Topcoder X

@ghost ghost self-assigned this Mar 17, 2021
@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/e96d0565-5c98-425e-bfe5-dfe6b8d2451d has been assigned to mfikria.

This is an automated message for luizrrodrigues via Topcoder X

@ghost
Copy link

ghost commented Mar 17, 2021

@luizrrodrigues Based on https://github.com/topcoder-platform/member-api/blob/develop/src/services/StatisticsService.js#L162-L220. So should we

  • remove groupIds params to retrieve normal user stats or
  • still need to retrieve the stats based on groupIds but with few separated request to handle URI limit?

@luizrrodrigues
Copy link
Collaborator

@fikzzzy still need to retrieve the stats based on groupIds but with few separated request to handle URI limit

@ghost
Copy link

ghost commented Mar 17, 2021

@luizrrodrigues alright, noted

@ghost
Copy link

ghost commented Mar 17, 2021

@luizrrodrigues It is ready to review. I have opened MR in #5438 and topcoder-platform/topcoder-react-lib#306

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented May 11, 2021 via email

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Is possible add my account (Prod) to TopGear group? luizrrodrigues

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented May 11, 2021 via email

@SathyaJayabal
Copy link
Collaborator

@SathyaJayabal You need access this via wipro community:
https://beta-community-app.topcoder.com/__community__/wipro/members/narayana/

oh yes, sorry, will try again

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , can u put the fix back on beta please?

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Done.

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented May 11, 2021 via email

@SathyaJayabal
Copy link
Collaborator

It looks good for me too. But i dont see nay challenge data for the user.
Screenshot 2021-05-12 at 8 28 40 AM

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Any luck to add my user to TopGear?

@Oanh-and-only-Oanh
Copy link

not yet.

@Oanh-and-only-Oanh
Copy link

can we continue to resolve this in the meantime?

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Yes,

@SathyaJayabal Can you check if more TopGear profiles looks good (Prod vs Beta), maybe top 5 profiles in Leaderboard.

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , the groups cals are good for the leaderboard top 5 users.
Screenshot 2021-05-13 at 9 20 02 AM
Screenshot 2021-05-13 at 9 20 50 AM
Screenshot 2021-05-13 at 9 21 17 AM
Screenshot 2021-05-13 at 9 21 59 AM
Screenshot 2021-05-13 at 9 22 50 AM

I still see one api call failing, not sure if it is relevant
Screenshot 2021-05-13 at 9 25 09 AM
Screenshot 2021-05-13 at 9 25 18 AM

@SathyaJayabal
Copy link
Collaborator

verified on staging
Screenshot 2021-05-13 at 8 24 49 PM
Screenshot 2021-05-13 at 8 25 15 PM

@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2021-05-13 at 9 52 32 PM
Screenshot 2021-05-13 at 9 52 48 PM

@luizrrodrigues
Copy link
Collaborator

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bash Issues going in next bug bash Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned topgear
Projects
None yet
Development

No branches or pull requests

5 participants