Skip to content

[$60] filter setting not saved when navigating from details page back to listings page #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Dec 16, 2020 · 9 comments
Closed

[$60] filter setting not saved when navigating from details page back to listings page #5259

Oanh-and-only-Oanh opened this issue Dec 16, 2020 · 9 comments
Assignees
@gets0ul
Labels
Challenge Listing P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted
Milestone
v1.7.2

Comments

@Oanh-and-only-Oanh
Copy link

describe the bug: filter setting not saved when navigating from details page back to listings page

Expected behavior: when user sets filters on the challenge details page and opens details page, those filter settings should remain when user goes back to the listings page

How to reproduce:

  1. go to topcoder.com/challenges
  2. filter for only design challenges (not f2f or task)
  3. select a challenge and go to the details page of that challenge
  4. navigate back to the listings page with arrow or back button
  5. The design track is still selected but not all types of selected as well (challenge, f2f, task) when only Challenge should be selected
@Oanh-and-only-Oanh Oanh-and-only-Oanh added Challenge Listing P1 Urgent (resolve within 24 hours) P2 Important (resolve within 3 days) labels Dec 16, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title filter setting not saved when navigating from details page back to listings page [$60] filter setting not saved when navigating from details page back to listings page Dec 16, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the P1 Urgent (resolve within 24 hours) label Dec 16, 2020
@luizrrodrigues luizrrodrigues modified the milestones: v1.7.1, v1.7.2 Dec 18, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30159903 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to
https://github.com/topcoder-platform/community-app/tree/filter-save-fix

run npm run test before PR

@gets0ul gets0ul self-assigned this Dec 24, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30159903 has been updated - it has been assigned to gets0ul.

This is an automated message for luizrrodrigues via Topcoder X

gets0ul added a commit to gets0ul/community-app that referenced this issue Dec 24, 2020
@gets0ul
fix: using saved challenge types in filter state
bd9aa27 
topcoder-platform#5259
@gets0ul gets0ul mentioned this issue Dec 24, 2020
Merged
luizrrodrigues added a commit that referenced this issue Dec 29, 2020
@luizrrodrigues
Merge pull request #5272 from gets0ul/issue_5259
8d2a231 
fix for #5259 - using saved challenge types in filter state
@luizrrodrigues
Copy link
Collaborator

Thanks @gets0ul

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Deployed in Stag env.

@SathyaJayabal
Copy link
Collaborator

verified in staging
filter.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Dec 29, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on staging
filter.mov 2.zip

@luizrrodrigues luizrrodrigues mentioned this issue Dec 29, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on prod
save filter.mov.zip

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30159903

This is an automated message for luizrrodrigues via Topcoder X

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging tcx_Paid labels Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
Challenge Listing P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted
Projects
None yet
Milestone
v1.7.2
Development

No branches or pull requests
4 participants
@gets0ul @luizrrodrigues @Oanh-and-only-Oanh @SathyaJayabal