Skip to content

[$50] Challenge prizes are showing wrong #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThomasKranitsas opened this issue Nov 17, 2020 · 14 comments
Closed

[$50] Challenge prizes are showing wrong #5193

ThomasKranitsas opened this issue Nov 17, 2020 · 14 comments

Comments

@ThomasKranitsas
Copy link
Contributor

Describe the bug
The community app is reading the prizes wrongly from the v5 API response. It's reading the first entry in the prizeSets array when it should find the one where the type is equal to placement

Expected behavior
The community app should find the correct prize set based on the type property.

Screenshots
Screenshot 2020-11-17 at 3 07 07 AM

In the above screenshot, it's showing the copilot payment instead of the prizes as the copilot prize set appears first in the array.

See the following two API responses for comparison:
Screenshot 2020-11-17 at 3 05 53 AM

@SathyaJayabal
Copy link
Collaborator

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 17, 2020

@ThomasKranitsas , prizes seem good now
Screenshot 2020-11-17 at 1 03 05 PM

@rootelement
Copy link
Contributor

It seems random. I've refreshed a couple times, and it goes back and forth. Not sure why.

@ThomasKranitsas
Copy link
Contributor Author

This should be fixed regardless. The prizeSets array may contain multiple objects and the frontend can’t just pick the first one blindly assuming it's going to be the placement prizes.

@luizrrodrigues
Copy link
Collaborator

@ThomasKranitsas Yep, agree. I'll as frontend getting the prize.

@luizrrodrigues luizrrodrigues self-assigned this Nov 17, 2020
@luizrrodrigues luizrrodrigues added this to the v1.6.1 milestone Nov 17, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Challenge prizes are showing wrong [$50] Challenge prizes are showing wrong Nov 17, 2020
@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Nov 17, 2020

I added prize amount. @luizrrodrigues you can decide how you want to get it fixed challenge or or tcx or you can do it yourself.

@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30152317 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30152317 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Deployed in Stag env tcx-202011 branch.

@SathyaJayabal
Copy link
Collaborator

Verified.
Screenshot 2020-11-20 at 9 49 50 AM

note: @luizrrodrigues , i was not able to reproduce the issue on production too, even after refreshing the challenge details links for many times.
Example links
https://www.topcoder.com/challenges/1df9351c-d027-4a0b-8793-975fda252de9
https://www.topcoder.com/challenges/996f3425-1723-45c2-afea-29a7b0b4e8a0

@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
Screenshot 2020-11-24 at 4 35 39 PM
Screenshot 2020-11-24 at 4 35 58 PM

@SathyaJayabal
Copy link
Collaborator

Screenshot 2020-11-24 at 7 44 30 PM

Screenshot 2020-11-24 at 7 44 33 PM

@luizrrodrigues
Copy link
Collaborator

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30152317

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants