Skip to content

Contentful media queries fix window resize #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Nov 9, 2020 · 4 comments
Closed

Contentful media queries fix window resize #5172

kkartunov opened this issue Nov 9, 2020 · 4 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production
Milestone
v1.5.3

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Nov 9, 2020 •
edited
Loading

Contentful media queries need to trigger on window resize too. Currently, page reload on the new resolution is required to trigger media queries. The scope is to change that behavior.

Test URL: https://community-app.topcoder.com/examples/contentful/viewport/72IxVCieryAuXbDe4uPPlk
Steps:

  1. Load the page at 1440px resolution
  2. Resize to 1024px
  3. Observe. Reload page
  4. video https://drive.google.com/file/d/1Tl0Uhapij5wEWjiVdp4WGj_sXn5wDSyE/view?usp=sharing
@kkartunov kkartunov self-assigned this Nov 9, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Nov 9, 2020
@kkartunov kkartunov added this to the Release by 11/10/2020 milestone Nov 9, 2020
luizrrodrigues added a commit that referenced this issue Nov 9, 2020
@luizrrodrigues
ci: deploy media-queries-fix to Stag env
7b1eaef 
Issue: #5172
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal ready for QA in Stag env.

@SathyaJayabal
Copy link
Collaborator

verified on staging (feature branch)
5172.mov.zip

@kkartunov kkartunov mentioned this issue Nov 10, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
media_queries.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Nov 10, 2020
Merged
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Nov 10, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
5172_prod.mov.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production
Projects
None yet
Milestone
v1.5.3
Development

No branches or pull requests
3 participants
@kkartunov @luizrrodrigues @SathyaJayabal