Skip to content

[$50] Ordered List and List item are not rendered correctly. #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jswheeler opened this issue Nov 5, 2020 · 19 comments
Closed

[$50] Ordered List and List item are not rendered correctly. #5168

jswheeler opened this issue Nov 5, 2020 · 19 comments
Assignees
Labels
P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid Terms Of Use
Milestone

Comments

@jswheeler
Copy link

Describe the bug
the <ol> and <li> html tags do not render for topcoder terms.
To Reproduce
Steps to reproduce the behavior:

  1. Open the admin tool for topcoder (admin.topcoder.com).
  2. Find the current terms called Standard Terms for Topcoder Competitions v2.2.
  3. See that the terms are using both hard coded numbers as well as the ol and li tags.
  4. Current terms are here https://www.topcoder.com/challenges/terms/detail/9ef9dec4-dddb-48c9-9cce-659db68bc5ac
  5. new terms are here https://www.topcoder.com/challenges/terms/detail/564a981e-6840-4a5c-894e-d5ad22e9cd6f

Expected behavior
The community app should render the terms properly. I've created a new terms object using the ol and li tags and the text not rendered

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Oanh-and-only-Oanh Oanh-and-only-Oanh added Terms Of Use P3 Normal (resolved within 7 days) labels Nov 6, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Ordered List and List item are not rendered correctly. [$50] Ordered List and List item are not rendered correctly. Nov 6, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30149549 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 6-8 hours and PR to
https://github.com/topcoder-platform/community-app/tree/tcx-202011

https://github.com/topcoder-platform/topcoder-react-lib/tree/tcx-202011

run npm run test before PR

@gets0ul gets0ul self-assigned this Nov 6, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30149549 has been updated - it has been assigned to gets0ul.

This is an automated message for luizrrodrigues via Topcoder X

@gets0ul
Copy link
Collaborator

gets0ul commented Nov 6, 2020

So, the expected solution is the ordered list item should be rendered in numbering format without needing to manually add number in the source term text.
Is that correct?

@Oanh-and-only-Oanh
Copy link

Correct.

@luizrrodrigues
Copy link
Collaborator

@gets0ul basically need to apply same format/style present in challenge spec

@gets0ul
Copy link
Collaborator

gets0ul commented Nov 7, 2020

@luizrrodrigues style fixed.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 10, 2020

@luizrrodrigues, accessing the new terms links on dev env gives a blank page error
https://community-app.topcoder-dev.com/challenges/terms/detail/9ef9dec4-dddb-48c9-9cce-659db68bc5ac

Screenshot 2020-11-10 at 9 26 37 AM

Accessing the terms from the challenge details page does not render the list items correctly
http://www.topcoder-dev.com/challenges/terms/detail/b11da5cd-713f-478d-90f4-f679ef53ee95
Screenshot 2020-11-10 at 9 26 55 AM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Nov 10, 2020
@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , will be good to have this on staging to test next time.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal This one was deployed in Stag.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 10, 2020

@luizrrodrigues , <li> is rendered correctly, but <ol> has double numbers
Screenshot 2020-11-10 at 9 50 35 AM
Screenshot 2020-11-10 at 9 50 42 AM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Double number is because this was added in CMS content, we'll need change this in CMS side.

@luizrrodrigues
Copy link
Collaborator

cc @jswheeler

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , marking this as pass, as the styles are applied correctly from community app side.

@SathyaJayabal SathyaJayabal removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Nov 10, 2020
@SathyaJayabal
Copy link
Collaborator

@jswheeler , please update the CMS content to not have numbers for the ordered list items.

@SathyaJayabal
Copy link
Collaborator

verified. for ordered list, numbers should be removed from CMS
Screenshot 2020-11-10 at 1 27 43 PM
Screenshot 2020-11-10 at 1 27 50 PM

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Nov 10, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-11-10 at 8 12 44 PM

@luizrrodrigues
Copy link
Collaborator

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30149549

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid Terms Of Use
Projects
None yet
Development

No branches or pull requests

5 participants