-
Notifications
You must be signed in to change notification settings - Fork 212
WIP - Implement New Forums Object #5041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is working in dev. I created this challenge in work manager: The challenge object looks like this: "discussions": [
{
"provider": "vanilla",
"name": "Forum Creation Test Discussion",
"id": "a730ce22-20f7-4566-b99f-ba8901999a31",
"type": "challenge",
"url": "https://vanilla.topcoder-dev.com/categories/6f87e86b-5694-4547-b267-35f3ddd87906"
}
], |
@Oanh-and-only-Oanh @luizrrodrigues do you have an ETA for this to be in Dev? We'd like to start E2E testing. |
@rootelement I'll push to QA env shortly |
@rootelement Done, deployed in QA env: Note: Applied logical above to Challenge Details. But we need discuss as change to Challenge Listing page and Challenge Card, both not support multiple forums link. |
Thank you sir, We are testing. I'm thinking we shouldn't show the forum link until the person is registered on the challenge? I will check that. We might not send it on the forum object if the person isn't registered. Not sure yet. Good so far. Don't worry about multiple yet. |
@Oanh-and-only-Oanh i thought this went out with the last release. This not being in prod will prevent us from using new forums on things launched out of Work Manager. @sushilshinde can this functionality go out first thing your daytime? cc: @mtwomey |
@rootelement @luizrrodrigues , able to see the forums link on details page even without logging in or registering to the challenge |
@rootelement @luizrrodrigues , while testing on prod backend,
|
@luizrrodrigues @Oanh-and-only-Oanh Not logged in or not registered users not able to see "Challenge Discussion" link as expected. But for some Challenges, the Discussions object does not have the URL field and hence even new challenges created using WM point to the old forums. |
The challenge object will now have a discussions node. The logic on the frontend should be:
type
:challenge
.type
:challenge
, build a link for the<a href="{url}">{name}</a>
legacy.forumId
that you do now.Note, it is valid to have multiple type challenge nodes, so the frontend code should list them in a
<ul>
type list. Order of the array is fine, you don't need to sort them alphabetically or anything.Example Challenge Object
The
options
array has nothing currently on the challenge forum. That's for future-proofing if we need to do registration for slack, or some other setup for other providers. Ignore that for now for Vanilla challenge forums.Reference Issue:
topcoder-platform/challenge-api#290
The text was updated successfully, but these errors were encountered: