Skip to content

[$75] "view more challenges" link sets filter to "open for registration" #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Sep 24, 2020 · 12 comments
Closed

[$75] "view more challenges" link sets filter to "open for registration" #5002

Oanh-and-only-Oanh opened this issue Sep 24, 2020 · 12 comments
Assignees
@gets0ul
Labels
QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 24, 2020 •
edited
Loading

Current behavior:
Currently seeing this behavior is logged out and logged in states.
how to reproduce bug:

  1. got o https://test-community-app.topcoder-dev.com/challenges?

  2. Make sure you're on "All challenges" filter. scroll down to "see more challenges" link at bottom of the page. See screenshot
    image

  3. click on "see more challenges" link

  4. observe that the filter is now on "Open for Registration". with following URL https://test-community-app.topcoder-dev.com/challenges?bucket=openForRegistration

Expected behavior:

  1. got o https://test-community-app.topcoder-dev.com/challenges?

  2. Make sure you're on "All challenges" filter. scroll down to "see more challenges" link at bottom of the page. See screenshot
    image

  3. click on "see more challenges" link

  4. Display more challenges without changing URL or filter setting
@Oanh-and-only-Oanh Oanh-and-only-Oanh added listing:re-implementation P2 Important (resolve within 3 days) labels Sep 24, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 24, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title "view more challenges" link sets filter to "ongoing challenges" [$60] "view more challenges" link sets filter to "ongoing challenges" Sep 24, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$60] "view more challenges" link sets filter to "ongoing challenges" [$60] "view more challenges" link sets filter to "open for registration" Sep 24, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143518 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/feature-refactor-challengelist
https://github.com/topcoder-platform/topcoder-react-lib/tree/feature-refactor-challengelist

run npm run test before PR

@gets0ul gets0ul self-assigned this Sep 24, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143518 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

@gets0ul gets0ul mentioned this issue Sep 24, 2020
Closed
@luizrrodrigues
Copy link
Collaborator

@gets0ul When click in View more challenges in a bucket, other bucket hides:
https://i.gyazo.com/d3beb4bc19349297c940f7ca30ae04cc.mp4

  • Example:
    1; Click in View more challenges in bucket My Challenges;
    2: Scroll down until all My Challenges loaded;
    3: Note Open for registration bucket was gone.

Issue 2 - When click in View more challenges scroll to top, need keep in currently position.

@gets0ul
Copy link
Collaborator

gets0ul commented Sep 29, 2020

@luizrrodrigues the original requirement did not mention this, only don't change the URL and sidebar currently selected. Can you bump the prize a bit?
I'll make a new PR for this and closing/removing the old one.

@Oanh-and-only-Oanh
Copy link
Author

@gets0ul, increasing the prize. Please PR.

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$60] "view more challenges" link sets filter to "open for registration" [$75] "view more challenges" link sets filter to "open for registration" Sep 29, 2020
@luizrrodrigues
Copy link
Collaborator

@gets0ul Cool.

@Oanh-and-only-Oanh Thanks.

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: Release by 10/1/2020, by 10/15/2020 Sep 29, 2020
@gets0ul
Copy link
Collaborator

gets0ul commented Sep 29, 2020

@luizrrodrigues New PR: #5017

luizrrodrigues added a commit that referenced this issue Oct 2, 2020
@luizrrodrigues
Merge pull request #5017 from gets0ul/issue_5002-fix
a352932 
Fix for Issue #5002 - Stays on main challenge listing when view more challenges is clicked.
@luizrrodrigues luizrrodrigues mentioned this issue Oct 2, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on test
view more.mov.zip

@SathyaJayabal
Copy link
Collaborator

verified on staging
5002.mov.zip

@crazyk07
Copy link

crazyk07 commented Oct 5, 2020

Payment failed: [500]: Failed to get billing detail for the project.

This is an automated message for crazyk via Topcoder X

@crazyk07 crazyk07 reopened this Oct 5, 2020
@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30143518

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gets0ul @luizrrodrigues @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal