[$25] Ongoing challenge bucket also includes open for registration challenges

[SathyaJayabal]

Ongoing challenge bucket also includes open for registration challenges

[LieutenantRoger]

@rootelement

Currently the On Going Challenge is requested like this:

Request URL: https://api.topcoder-dev.com/v5/challenges/?status=Active&currentPhaseName=Submission&perPage=10&page=1&sortBy=updated&sortOrder=desc&tracks[]=Dev&tracks[]=Des&tracks[]=DS&tracks[]=QA

Please advise if we have another filter to exclude the 'Open For Registrationchallenges fromOn Going Challenges`

[Oanh-and-only-Oanh]

Just to clarify, we do not want Ongoing Challenges filter to show Open for Registration challenges. The behavior in PROD right now seems to be the same- they are separate.

[crazyk07]

Contest https://www.topcoder.com/challenges/30143199 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[luizrrodrigues]

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/feature-refactor-challengelist
https://github.com/topcoder-platform/topcoder-react-lib/tree/feature-refactor-challengelist

run npm run test before PR

[crazyk07]

Contest https://www.topcoder.com/challenges/30143199 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

[cagdas001]

@luizrrodrigues We were handling the bucket filtering at frontend before, but I now see these filtering codes are commented out with this commit: dc52de0 What is your purpose by this? You're intending to handle filtering with a pure backend solution? (i.e. with query parameters)

[Oanh-and-only-Oanh]

Yes, this whole revamp is to improve the performance of the challenge listings page (filters, buckets, tags, search, etc) on this page using backend solution.

[luizrrodrigues]

Yes, filters will be done in backend side, so ever when apply a filter will call the api to get results.

[cagdas001]

I got your point, but this call (#4975 (comment)) itself cannot purely handle the filtering for ongoing challenges. Because some challenges may have both Registration and Submission phases (so both phases are open) in currentPhaseNames field. For instance, http://api.topcoder-dev.com/v5/challenges/c5d082e2-8045-49c3-82c1-054d4a1dd537 As you can see, "currentPhaseNames":["Registration","Submission"] So backend will return such challenges, even if you use ?currentPhaseName=Submission filter

I can add a small filter at frontend in addition to this call, to filter out such challenges. But in this case we cannot maintain the default PAGE_SIZE of 10. (it currently loads 10 challenges for each scroll) There'll be less challenges in each call, since we'll filter out some of them at frontend.

[luizrrodrigues]

@cagdas001 Have tried this one: https://github.com/topcoder-platform/challenge-api/blob/6c897144a90e56ea6148fd5f415dacfd0aeadf76/docs/swagger.yaml#L264-L269

[cagdas001]

While this filter should work in theory, but V5 Challenge API has some issues with these date fields (registrationEndDate etc.) I have explained it in one of previous issues: #4755 (comment) So it will probably end up with wrong challenges in bucket and a QA Fail if I apply this filter.

For e.g. the challenge I have shown in the above comment will be affected from this issue. The real registration end date is 2020-10-08T06:26:00Z (check the scheduledEndDate of registration phase) But challenge.registrationEndDate is 2020-09-21T06:32:33Z

[luizrrodrigues]

@cagdas001 Checking...

[luizrrodrigues]

@cagdas001 Please use this filter: #4975 (comment) and any other available filter here: https://github.com/topcoder-platform/challenge-api/blob/6c897144a90e56ea6148fd5f415dacfd0aeadf76/docs/swagger.yaml if needed.

If we have issue with API, I'll request help from API team.

Thanks.

[cagdas001]

Okay, it now calls https://api.topcoder-dev.com/v5/challenges/?status=Active&currentPhaseName=Submission&registrationEndDateEnd=2020-10-01T17%3A56%3A54.698Z&perPage=10&page=1&sortBy=updated&sortOrder=desc&tracks[]=Dev&tracks[]=Des&tracks[]=DS&tracks[]=QA to load ongoing challenges. During the call, registrationEndDateEnd is being set to new Date().toISOString() So, it should theoretically return the Active challenges that registration phase has ended & Submission phase is open

If you notice any defect (missing/wrong challenge etc), first check if this endpoint returning challenges correctly

[cagdas001]

The commit (c0c7eeb) is pushed directly to upstream (feature-refactor-challengelist branch).

[luizrrodrigues]

topcoder-platform/challenge-api#322

[luizrrodrigues]

Contest https://www.topcoder.com/challenges/30143199 has been updated - luizrrodrigues has been unassigned.

This is an automated message for luizrrodrigues via Topcoder X

[SathyaJayabal]

We are hiding this bucket.

[SathyaJayabal]

#5073

[luizrrodrigues]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

[SathyaJayabal]

reopening for payment processing

[luizrrodrigues]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30143199

This is an automated message for luizrrodrigues via Topcoder X