Skip to content

[$50] My Challenges bucket and Open for registration bucket challenges are not sorted by Most Recent #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Sep 21, 2020 · 12 comments
Closed

[$50] My Challenges bucket and Open for registration bucket challenges are not sorted by Most Recent #4973

SathyaJayabal opened this issue Sep 21, 2020 · 12 comments
Assignees
@gets0ul
Labels
QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 21, 2020 •
edited
Loading

My Challenges bucket and Open for registration bucket challenges are not sorted by Most Recent
See below comparison with prod.
Most recent must sort based on challenge started date (like in prod)
Screenshot 2020-09-21 at 7 53 20 PM
@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) listing:re-implementation labels Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title My Challenges bucket and Open for review bucket challenges are not not sorted by Most Recent My Challenges bucket and Open for review bucket challenges are not sorted by Most Recent Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: Release by 10/1/2020, Release by 10/8/2020 Sep 21, 2020
@LieutenantRoger
Copy link
Collaborator

@rootelement Currently the sorting function is implemented like this:

https://api.topcoder-dev.com/v5/challenges/?status=Active&currentPhaseName=Registration&perPage=10&page=1&sortBy=updated&sortOrder=desc&tracks[]=Dev&tracks[]=Des&tracks[]=DS&tracks[]=QA

Note the field: sortBy=updated&sortOrder=desc, please let me know if there's counter part in V5 API to sort the challenges with Most Recent format

@LieutenantRoger LieutenantRoger added the Need clarification Need clarification to proceed fixing the issue further label Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title My Challenges bucket and Open for review bucket challenges are not sorted by Most Recent [$50] My Challenges bucket and Open for review bucket challenges are not sorted by Most Recent Sep 22, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143201 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/feature-refactor-challengelist
https://github.com/topcoder-platform/topcoder-react-lib/tree/feature-refactor-challengelist

run npm run test before PR

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the Need clarification Need clarification to proceed fixing the issue further label Sep 22, 2020
@gets0ul gets0ul self-assigned this Sep 23, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143201 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

@gets0ul gets0ul mentioned this issue Sep 23, 2020
Merged
@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Sep 24, 2020 •
edited
Loading

@SathyaJayabal to confirm, all buckets need be sorted by startDate instead updated right?

@luizrrodrigues luizrrodrigues added the Need clarification Need clarification to proceed fixing the issue further label Sep 24, 2020
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , correct. The most recent is the default sort order for the buckets.

@luizrrodrigues
Copy link
Collaborator

@gets0ul Please check: #4991 (review)

@luizrrodrigues luizrrodrigues added nav_Feedback and removed Need clarification Need clarification to proceed fixing the issue further tcx_ReadyForReview labels Sep 24, 2020
luizrrodrigues added a commit that referenced this issue Sep 29, 2020
@luizrrodrigues
Merge pull request #4991 from gets0ul/issue-4973
692b747 
Fix for Issue #4973
@SathyaJayabal
Copy link
Collaborator Author

verified on staging for My Challenges and Open for registration

Screenshot 2020-09-29 at 10 27 15 AM

@SathyaJayabal
Copy link
Collaborator Author

verified on staging for my challenges and Open for registration
Screenshot 2020-10-05 at 2 55 07 PM

@crazyk07
Copy link

crazyk07 commented Oct 5, 2020

Payment failed: [500]: Failed to get billing detail for the project.

This is an automated message for crazyk via Topcoder X

@crazyk07 crazyk07 reopened this Oct 5, 2020
@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30143201

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
QA Pass in Staging tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@LieutenantRoger @gets0ul @luizrrodrigues @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal