-
Notifications
You must be signed in to change notification settings - Fork 212
Blank screen displayed on clicking the Technology tags in the Challenge listings and Details pages #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@LieutenantRoger : Filtering the challenges according to the keyword (Technology) is not working. video: |
@LieutenantRoger , when I search by keywords I see more number of challenges |
@SathyaJayabal Are you sure the staging is deploying my code ? Please see the staging when I have Other as the filter, it looked like this: https://take.ms/vJaTs And in my local, before filter: After filter I can see the number has reduced with the filter applied. Please double check on this, thanks. |
@SathyaJayabal Please double check based on the snapshots I provided above. |
The keyword under Have you tried otherwise keywords ? This is very possibly due to the API issue. |
@LieutenantRoger looks like API issue: Call (without tags): https://api.topcoder-dev.com/v5/challenges/?status=Active&isLightweight=true&perPage=1&tracks[]=Dev&tracks[]=Des&tracks[]=DS&tracks[]=QA no auth: 560 Cal (with tags)l: https://api.topcoder-dev.com/v5/challenges/?status=Active&isLightweight=true&perPage=1&tags[]=Java&tracks[]=Dev&tracks[]=Des&tracks[]=DS&tracks[]=QA no auth: 26 |
@luizrrodrigues needs to add |
@sushilshinde @luizrrodrigues, is this still an API issue? |
Testing on this environment, every tag I clicked on works fine. |
This is the only issue I'm seeing now. If I search for |
@rootelement , it is not working in staging. |
@ThomasKranitsas I don't understand what's going on here... The query with tags looks like this: if (criteria.tags) {
if (criteria.includeAllTags) {
for (const tag of criteria.tags) {
boolQuery.push({ match_phrase: { tags: tag } })
}
} else {
for (const tag of criteria.tags) {
shouldQuery.push({ match: { tags: tag } })
}
}
} Should that second shouldQuery be If I query from postman with my jwt in prod, i get: If I query the same with a jwt from a non-privileged user in prod (jcori_arena), i get 91 items, and they're coming back without the tag in the tags array (example ID: |
@ThomasKranitsas this is the built ES query from the server logs.
If I run this query, I get 1 result back:
|
reducing the priority as the blank screen issue is resolved |
We're testing a fix to the search difference in dev currently. The tags issue should be fixed, but we will report back in a bit. |
It seems to be working well in dev. This will be queued for release shortly. The ability to type in the search box and filter on tags is a new feature request, and has been opened on the challenge api repo as a separate topic. |
@rootelement, the new feature request, is 1) the ability to type in search box and match on "Challenge title" and "tags". 2) However, we also want the ability to display list of challenges with a specific tag if a "tag" is selected from the Challenge Listings page or Details page. I believe, this is second point refers to this ticket. |
Yes, and that's what I said is done and working. so this ticket is solved. |
@rootelement , let us know when the tags fix is released to prod. |
Verified on staging. |
Description:
Blank screen displayed on clicking the Technology tags in the Challenge listings page
steps to Reproduce:
Expected Result:
Challenges should be filtered (according the particular technology) and listed.
Screenshot:
Video:
Filter_by_technology.zip
The text was updated successfully, but these errors were encountered: