Skip to content

Challenge details page displaying a blank screen #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandhiyakavi opened this issue Sep 21, 2020 · 10 comments
Closed

Challenge details page displaying a blank screen #4965

sandhiyakavi opened this issue Sep 21, 2020 · 10 comments
Assignees

Comments

@sandhiyakavi
Copy link
Collaborator

Description:

Challenge details page displaying a blank screen

image

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Sep 26, 2020

The PRs:

Community App: #5008

topcoder-react-lib: topcoder-platform/topcoder-react-lib#259

Note: the recommended challenges are disabled for now per the discussion in the slack challenge.

luizrrodrigues referenced this issue in topcoder-platform/topcoder-react-lib Sep 29, 2020
@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger I see changes done in community-app and I think need first this one too:
topcoder-platform/topcoder-react-lib@d7e336e#r42801128

After change lib need make sure to update all components using that lib.


@sushilshinde We good to comment a lot of code block instead remove?
#5008 (comment)

@luizrrodrigues luizrrodrigues added Need clarification Need clarification to proceed fixing the issue further tcx_Feedback and removed tcx_ReadyForReview labels Sep 29, 2020
@mtwomey
Copy link
Contributor

mtwomey commented Sep 29, 2020

What's needed on this one to proceed @luizrrodrigues ?

@luizrrodrigues
Copy link
Collaborator

@mtwomey vars was changed topcoder-react-lib, but this not changed in all places in community-app, so some places will broken if not reflect the changes done in lib.

Changes in lib:

export const COMPETITION_TRACKS = {
  DATA_SCIENCE: 'Data Science',
  DESIGN: 'Design',
  DEVELOP: 'Development',
  QA: 'Quality Assurance',
}

to

export const COMPETITION_TRACKS = {
  DS: 'Data Science',           <===
  DES: 'Design',                <===
  DEV: 'Development',           <===
  QA: 'Quality Assurance',
}

So need make sure all ref to COMPETITION_TRACKS.DATA_SCIENCE, COMPETITION_TRACKS.DESIGN and COMPETITION_TRACKS.DEVELOP was changed to COMPETITION_TRACKS.DS, COMPETITION_TRACKS.DES and COMPETITION_TRACKS.DEV respectively

@mtwomey
Copy link
Contributor

mtwomey commented Sep 29, 2020

@luizrrodrigues Do you know why this was changed in the lib? Should we change it back for now, or should we just update the refs?

@luizrrodrigues
Copy link
Collaborator

@mtwomey This looks like unnecessary change.

@LieutenantRoger Can you share why was need that change in lib?

@LieutenantRoger
Copy link
Collaborator

I remember I need to send the tracks related parameter when fetching V5 API, the value I changed are the ones used in the V5 API.
I made the change so I don't need do the conversion when calling the API.

@sushilshinde
Copy link
Collaborator

I had a chat with @LieutenantRoger he will make necessary changes to community-app

@LieutenantRoger
Copy link
Collaborator

@luizrrodrigues I have updated the PR. The change is to align with the V5 challenge api filter naming.

@SathyaJayabal
Copy link
Collaborator

verified on test
Screenshot 2020-10-01 at 10 37 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants