Skip to content

Gig work application page #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkartunov opened this issue Sep 10, 2020 · 14 comments
Closed

Gig work application page #4891

kkartunov opened this issue Sep 10, 2020 · 14 comments
Assignees
Labels
Contentful-DEV Internal development operations for Contentful Gig Work P4 Low (resolve within 2 weeks) QA Pass in PROD Passed verification on Production
Milestone

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Sep 10, 2020

Should be functional and follow design https://marvelapp.com/prototype/f0i4ece/screen/72147213
Exact fields are TBD by the team.

@kkartunov kkartunov self-assigned this Sep 10, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Sep 10, 2020
@kkartunov kkartunov added this to the By 9/24/2020 milestone Sep 10, 2020
@kkartunov kkartunov added P4 Low (resolve within 2 weeks) Gig Work labels Sep 10, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: By 9/24/2020, Release by 10/1/2020 Sep 23, 2020
kkartunov added a commit that referenced this issue Sep 29, 2020
kkartunov added a commit that referenced this issue Sep 30, 2020
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 30, 2020

@kkartunov

  1. Are the below 3 fields mandatory ? (the first 2 are mandatory as per the design)
  2. Do we have any default vales that are pre selected for these fields?

Screenshot 2020-09-30 at 2 53 55 PM

  1. Blank page displayed on deleting available from date field
  2. No validation for phone number. The field accepts any character

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Sep 30, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal
3. is now fixed. Please re-test it.
4. Is expected like that to support all kinds of phone formats for numbers. We trust users that they will provide correct numbers so we are able to call them for the gig work opportunity.

@SathyaJayabal
Copy link
Collaborator

@kkartunov , 3 is verified.

@kkartunov
Copy link
Collaborator Author

@SathyaJayabal for 2.&3.

They are not mandatory
They don't have any default options selected

That is what team decision is on that.

@SathyaJayabal
Copy link
Collaborator

Thanks @kkartunov

@SathyaJayabal SathyaJayabal added QA Pass and removed Need clarification Need clarification to proceed fixing the issue further labels Sep 30, 2020
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal @kkartunov I think we need run QA again in this one, looks like changes made after QA Pass.

changes: 0633ef3

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Oct 1, 2020

@kkartunov,

  1. Some of the mandatory fields dont show the error message when left empty
  2. The mandatory field error message doesn't go away after adding data to the field
  3. The "Apply to this Job" button is not enabled even after entering all mandatory data

Previously, the "Apply to this Job" button was enabled only after all mandatory data was entered.

https://drive.google.com/file/d/1HU5Rz5zk6L3uDt8dWBKgV_Xj5TDdPeul/view?usp=sharing

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA Merged for QA labels Oct 1, 2020
kkartunov added a commit that referenced this issue Oct 1, 2020
@kkartunov kkartunov removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Oct 1, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal fix for validation issues is deploying. Please, test in ~15 min. Thanks

@SathyaJayabal
Copy link
Collaborator

@kkartunov, for the CV upload, it allows only .pdf and .docx file when you browse for the files. But you are able to drag and drop other file formats (.zip, mp4, .png etc) and submit your application. What file formats are accepted ?
Screenshot 2020-10-01 at 1 48 55 PM

Otherwise validation looks good.

@SathyaJayabal
Copy link
Collaborator

fixed
Screenshot 2020-10-01 at 2 27 28 PM

@SathyaJayabal SathyaJayabal modified the milestones: Release by 10/1/2020, v1.2.4 Oct 1, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
@kkartunov, validation not happening for mandatory fields (fname, lname, email and city) for logged in users.
gigs app.mov.zip

@SathyaJayabal
Copy link
Collaborator

@kkartunov , as discussed on slack, we are tracking the above validation case in a new issue
#5034

@kkartunov
Copy link
Collaborator Author

@SathyaJayabal than you. We will address the weird issue as hot-fix in the #5034

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Oct 1, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-10-01 at 7 50 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contentful-DEV Internal development operations for Contentful Gig Work P4 Low (resolve within 2 weeks) QA Pass in PROD Passed verification on Production
Projects
None yet
Development

No branches or pull requests

4 participants