Skip to content

Gig Work - fixes #2 #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkartunov opened this issue Sep 7, 2020 · 5 comments
Closed

Gig Work - fixes #2 #4868

kkartunov opened this issue Sep 7, 2020 · 5 comments
Assignees
Labels
Gig Work QA Pass in PROD Passed verification on Production Test Env Environment
Milestone

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Sep 7, 2020

@kkartunov kkartunov self-assigned this Sep 7, 2020
kkartunov added a commit that referenced this issue Sep 8, 2020
kkartunov added a commit that referenced this issue Sep 8, 2020
@kkartunov kkartunov mentioned this issue Sep 8, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal this is ready for QA.
Test urls:

@kkartunov kkartunov added this to the By 9/10/2020 release milestone Sep 9, 2020
@SathyaJayabal
Copy link
Collaborator

For the modal on the edu page.

  1. There is too much space above the heading
  2. Modal is closed by the X sign on the top right, where as in the TCO modals, we have a RETURN TO PAGE button

Screenshot 2020-09-09 at 1 39 57 PM

Screenshot 2020-09-09 at 1 40 35 PM

verified other fixes
Screenshot 2020-09-09 at 1 33 17 PM

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Sep 9, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal

  1. Is content. I reduced the top space.
  2. This is a generic modal thus should not have the button as it could be at any page or even part of it.

This one is good to go. Thank You

@SathyaJayabal SathyaJayabal added QA Pass in Dev and removed Need clarification Need clarification to proceed fixing the issue further labels Sep 9, 2020
@sandhiyakavi
Copy link
Collaborator

Verified in Staging Env.

image

image

@sandhiyakavi
Copy link
Collaborator

Verified on Production.Working as expected.

image

image

@sandhiyakavi sandhiyakavi added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gig Work QA Pass in PROD Passed verification on Production Test Env Environment
Projects
None yet
Development

No branches or pull requests

3 participants