Skip to content

Colored member handles in leaderboards #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Aug 7, 2020 · 5 comments
Closed

Colored member handles in leaderboards #4722

kkartunov opened this issue Aug 7, 2020 · 5 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production TCO_leaderboard
Milestone
v1.6.4

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Aug 7, 2020 •
edited
Loading

Update leaderboards to support colored member handles as now some looker APIs return the required rating data.
In the case of rating data not present in API response then render handles as blue links.

Match design https://marvelapp.com/prototype/ed9e597/screen/70330089
@kkartunov kkartunov self-assigned this Aug 7, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Aug 7, 2020
@kkartunov kkartunov changed the title Colored member handles Colored member handles in leaderboards Aug 10, 2020
kkartunov added a commit that referenced this issue Aug 20, 2020
@kkartunov
#4722 fixed data loading issues
629b777
@kkartunov kkartunov added this to the By 10/29/2020 milestone Oct 21, 2020
@kkartunov kkartunov removed this from the By 10/29/2020 milestone Nov 17, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal will be no sorting on the table as it will change the podium places thus not good.

@SathyaJayabal
Copy link
Collaborator

@kkartunov , verified.
Does it apply only for tco21 for now?
Screenshot 2020-12-03 at 5 27 35 PM

@luizrrodrigues luizrrodrigues added this to the v1.6.3 milestone Dec 3, 2020
@kkartunov kkartunov mentioned this issue Dec 3, 2020
Merged
@luizrrodrigues luizrrodrigues modified the milestones: v1.6.3, v1.6.4 Dec 3, 2020
kkartunov added a commit that referenced this issue Dec 4, 2020
@kkartunov
Final fixes for #4722
6be98f8
@kkartunov
Copy link
Collaborator Author

@luizrrodrigues this now ready to release with the next milestone.

@SathyaJayabal
Copy link
Collaborator

verified on staging (develop) for TCO21
Screenshot 2020-12-11 at 11 50 21 AM

@luizrrodrigues luizrrodrigues mentioned this issue Dec 11, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-12-11 at 3 05 28 PM

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production TCO_leaderboard
Projects
None yet
Milestone
v1.6.4
Development

No branches or pull requests
3 participants
@kkartunov @luizrrodrigues @SathyaJayabal