[$50]Hundreds of resource api calls made on the dashboard page

[SathyaJayabal]

https://beta-community-app.topcoder.com/my-dashboard
Hundreds of resource api calls made on the dashboard page

dashboard (1).mp4.zip

[crazyk07]

Contest https://www.topcoder.com/challenges/30136517 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[sushilshinde]

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

[crazyk07]

Contest https://www.topcoder.com/challenges/30136517 has been updated - it has been assigned to daga_sumit.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30136517 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

[gets0ul]

Sorry @sumitdaga signed it first.

[crazyk07]

Contest https://www.topcoder.com/challenges/30136517 has been updated - it has been assigned to daga_sumit.

This is an automated message for crazyk via Topcoder X

[sumitdaga]

thanks @gets0ul

[sumitdaga]

@SathyaJayabal
The /resources/${memberId}/challenges endpoint is called without any filter here https://github.com/topcoder-platform/topcoder-react-lib/blob/integration-v5-challenge-api/src/services/members.js#L349
which returns all challenges for a member and not just the active challenges
and for some members, number of challenges they have registered to could be more than 1000

moreover i checked the resources api too ...it seems the filters (like status=Active) are not even implemented in the api
https://github.com/topcoder-platform/resources-api/blob/develop/src/services/ResourceService.js#L394

thanks

[SathyaJayabal]

@sumitdaga , Please use the challenge-api call that is used to populate the my challenges bucket in the challenge listings page.

cc @sushilshinde, please confirm if this approach is fine?

[sumitdaga]

@SathyaJayabal
ok so with the above call, that is, /resources/${memberId}/challenges, we are just getting the role of the user in their active challenges and we already have roles (this is an array compared to a single value from the resources api) from here https://github.com/topcoder-platform/community-app/blob/integration-v5-challenge-api/src/shared/components/Dashboard/CurrentActivity/Challenges/ChallengeCard/index.jsx#L76
which infact comes from the same api which is used in challenge listing page

so in essence we don't even need to call this /resources/${memberId}/challenges api at all, as we already have the roles info.
I am not sure if all the roles a user has in that challenge need to be shown or just any one of the roles, in the challenge card on the dashboard.

[sushilshinde]

@sumitdaga

https://api.topcoder.com/v5/challenges/?status=Active&memberId=40623428&perPage=99&page=1

Returns all dashboard required challenges, we don't need resources calls here

[crazyk07]

Contest https://www.topcoder.com/challenges/30136517 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

[cagdas001]

PR: topcoder-platform/topcoder-react-lib#220

It will fetch only Active challenges

[SathyaJayabal]

This should also fix the issue of My Active cHallenges displaying all active challenges before displaying only My Challenges

[sushilshinde]

@cagdas001 https://test-community-app.topcoder-dev.com/my-dashboard

Still makes too many calls

[cagdas001]

Still makes too many calls

@sushilshinde I have re-checked this. I'm only seeing a limited number of requests to /resources?challengeId= endpoint.

We need to make one request per challenge to get role details and this would be the minimum number of requests as per the API design. It doesn't allow to query multiple challenges at once, or to query the all of the resources user has

We need role details for the following field(s)

So, some options:

1. We can show only a limited number of challenges (for e.g. 20 challenges), and can add a View More button below.
2. We can make a change at resources-api, in order to query multiple challengeIds at once, or to query ALL resources user (memberId) has.

This should also fix the issue of My Active cHallenges displaying all active challenges before displaying only My Challenges

@SathyaJayabal Could you elaborate this one a bit more, please? You mean it displays all the active challenges, instead of displaying the user's challenges?

[SathyaJayabal]

@cagdas001 , when we access the dashboard for the first time, we dont see the correct number of My Active Challenges. After refresh we see the correct number.

[SathyaJayabal]

@sushilshinde @cagdas001 , in production, a member will not have more than a few active challenges. So there will not be that many resource api calls, even if we call it once per challenge.

@sushilshinde Do you think we can go ahead with the above implementation?

[luizrrodrigues]

@SathyaJayabal I think this will be a problem with Admins/CA/CP because they is part of a lot of projects.

[luizrrodrigues]

@sushilshinde Need confirmation in this one. #4714 (comment)