[$70]Submission count does not include checkpoint submissions #4681

SathyaJayabal · 2020-07-24T05:26:24Z

Submission count mismatch for design contests between v4 and v5

example
https://beta-community-app.topcoder.com/challenges/208e6774-8263-4c3a-a77f-afe4c84a888f
https://www.topcoder.com/challenges/30132044

cc @lakshmiathreya

SathyaJayabal · 2020-07-24T05:26:38Z

cc @sushilshinde @rootelement

rootelement · 2020-07-28T01:52:21Z

This was the sync issue I mentioned over the weekend. This should be fixed now.

SathyaJayabal · 2020-07-30T14:45:34Z

@rootelement , We still have some design challenges where the submission count is incorrect.
few more examples:
https://beta-community-app.topcoder.com/challenges/4424fa70-9305-46a6-b052-4e2bd237f3b3
https://beta-community-app.topcoder.com/challenges/4424fa70-9305-46a6-b052-4e2bd237f3b3
https://beta-community-app.topcoder.com/challenges/45c9f6df-9cb4-462d-9b0a-ff440f27c740
https://beta-community-app.topcoder.com/challenges/e33972bd-1186-4e0e-aa10-7660a506455f

SathyaJayabal · 2020-08-05T13:44:36Z

The checkpoint submissions are not accounted for in the submission count.
So when the challenge is in checkpoint submission phase, even though there are submissions, the count is always zero.

This will be confusing to the members. example:

cc @Oanh-and-only-Oanh @lakshmiathreya @rootelement @sushilshinde @mtwomey , do you think this is a must fix for the first release?

rootelement · 2020-08-05T16:48:30Z

This is not a backend issue. The info is in the object, the frontend needs to update logic.
numOfSubmissions + (numOfCheckpointSubmissions || 0)

{
        "id": "68f0ebff-314d-4c3c-87ac-3787b6a53783",
        "legacyId": "30135512",
        "status": "Active",
        "track": "Design",
        "type": "Challenge",
        "trackId": "5fa04185-041f-49a6-bfd1-fe82533cd6c8",
        "typeId": "927abff4-7af9-4145-8ba1-577c16e64e2e",
        "legacy": {
            "track": "DESIGN",
            "subTrack": "WEB_DESIGNS",
            "forumId": 772046,
            "directProjectId": 27469,
            "reviewType": "INTERNAL",
            "screeningScorecardId": 30001363,
            "reviewScorecardId": 30001031
        },
        "task": {
            "isTask": false,
            "isAssigned": false,
            "memberId": null
        },
        "name": "Juno Technology Support Sharepoint Redesign Challenge",
        "description": REDACTED_FOR_SIZE,
        "descriptionFormat": "HTML",
        "projectId": 24816,
        "created": "2020-08-01T09:19:41Z",
        "createdBy": "PereViki",
        "updated": "2020-08-04T05:24:19Z",
        "updatedBy": "jaya.dhaka",
        "timelineTemplateId": "4a59472b-0743-4dae-9739-1f5b327e1255",
        "phases": [
            {
                "duration": 172800,
                "scheduledEndDate": "2020-08-03T12:18:35Z",
                "actualEndDate": "2020-08-03T12:18:35Z",
                "isOpen": false,
                "name": "Specification Submission",
                "phaseId": "fb21431c-119e-4bc7-b447-d0af3f2be6b4",
                "actualStartDate": "2020-08-03T12:18:18Z",
                "id": "74e5def2-8e1c-400d-a8ee-488922ad54ae",
                "scheduledStartDate": "2020-08-03T12:18:18Z"
            },
            {
                "duration": 21600,
                "scheduledEndDate": "2020-08-03T12:23:43Z",
                "actualEndDate": "2020-08-03T12:23:43Z",
                "isOpen": false,
                "name": "Specification Review",
                "phaseId": "2752454b-0952-4a42-a4f0-f3fb88a9b065",
                "actualStartDate": "2020-08-03T12:18:51Z",
                "id": "296db90a-51d3-4619-b91c-e56079e3ad96",
                "scheduledStartDate": "2020-08-03T12:18:51Z"
            },
            {
                "duration": 254100,
                "scheduledEndDate": "2020-08-06T11:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": true,
                "name": "Registration",
                "phaseId": "a93544bc-c165-4af4-b55e-18f3593b457a",
                "actualStartDate": "2020-08-03T12:25:08Z",
                "id": "c5a3a2bc-b3d8-440e-8a60-cdbee411b407",
                "scheduledStartDate": "2020-08-03T12:25:08Z"
            },
            {
                "duration": 253800,
                "scheduledEndDate": "2020-08-06T11:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": true,
                "name": "Checkpoint Submission",
                "phaseId": "d8a2cdbe-84d1-4687-ab75-78a6a7efdcc8",
                "actualStartDate": "2020-08-03T12:30:59Z",
                "id": "326c73b8-d753-43d4-9203-94cd74f5b901",
                "scheduledStartDate": "2020-08-03T12:30:59Z"
            },
            {
                "duration": 858540,
                "scheduledEndDate": "2020-08-13T11:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": true,
                "name": "Submission",
                "phaseId": "6950164f-3c5e-4bdc-abc8-22aaf5a1bd49",
                "actualStartDate": "2020-08-03T12:31:47Z",
                "id": "fa79b274-6d1d-45ad-9e1a-54f6c6becef5",
                "scheduledStartDate": "2020-08-03T12:31:47Z"
            },
            {
                "duration": 14400,
                "scheduledEndDate": "2020-08-06T15:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": false,
                "name": "Checkpoint Screening",
                "phaseId": "ce1afb4c-74f9-496b-9e4b-087ae73ab032",
                "actualStartDate": "2020-08-05T12:24:40Z",
                "id": "b9f116e4-0bed-434b-9550-daf75c0baf7b",
                "scheduledStartDate": "2020-08-06T11:00:00Z"
            },
            {
                "duration": 244800,
                "scheduledEndDate": "2020-08-09T11:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": false,
                "name": "Checkpoint Review",
                "phaseId": "84b43897-2aab-44d6-a95a-42c433657eed",
                "actualStartDate": "2020-08-05T12:24:40Z",
                "id": "75ce048f-c142-41a2-9996-dbdc1aea2fd6",
                "scheduledStartDate": "2020-08-06T15:00:00Z"
            },
            {
                "duration": 14400,
                "scheduledEndDate": "2020-08-13T15:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": false,
                "name": "Screening",
                "phaseId": "2d7d3d85-0b29-4989-b3b4-be7f2b1d0aa6",
                "actualStartDate": "2020-08-05T12:24:40Z",
                "id": "1d60dd97-2b05-4c71-a794-a6a2e66be1c4",
                "scheduledStartDate": "2020-08-13T11:00:00Z"
            },
            {
                "duration": 518400,
                "scheduledEndDate": "2020-08-19T15:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": false,
                "name": "Review",
                "phaseId": "aa5a3f78-79e0-4bf7-93ff-b11e8f5b398b",
                "actualStartDate": "2020-08-05T12:24:40Z",
                "id": "6ff0fd75-a9c5-4e9a-a941-d3797f46456c",
                "scheduledStartDate": "2020-08-13T15:00:00Z"
            },
            {
                "duration": 432000,
                "scheduledEndDate": "2020-08-24T15:00:00Z",
                "actualEndDate": "2020-08-05T12:24:40Z",
                "isOpen": false,
                "name": "Approval",
                "phaseId": "ad985cff-ad3e-44de-b54e-3992505ba0ae",
                "actualStartDate": "2020-08-05T12:24:40Z",
                "id": "88e41ea5-06ec-4901-a900-dce868d5fe0d",
                "scheduledStartDate": "2020-08-19T15:00:00Z"
            }
        ],
        "terms": [
            {
                "roleId": "732339e7-8e30-49d7-9198-cccf9451e221",
                "id": "9ef9dec4-dddb-48c9-9cce-659db68bc5ac"
            },
            {
                "roleId": "3eedd4a4-3c68-4f68-8de4-a1ca5c2055e5",
                "id": "e3370508-a541-4b9c-b83f-3bad33dcca4c"
            },
            {
                "roleId": "ff556573-5da6-4392-b38c-08c1d7599c4a",
                "id": "e3370508-a541-4b9c-b83f-3bad33dcca4c"
            },
            {
                "roleId": "e0544b94-6420-4afc-8f63-238eddc751b9",
                "id": "e3370508-a541-4b9c-b83f-3bad33dcca4c"
            },
            {
                "roleId": "0e9c6879-39e4-4eb6-b8df-92407890faf1",
                "id": "aaa50b65-fb27-44e1-8398-03d70ce4ac5a"
            },
            {
                "roleId": "cfe12b3f-2a24-4639-9d8b-ec86726f76bd",
                "id": "11ad4ba8-c3ec-4cf9-98e6-c7f43a5bd89f"
            },
            {
                "roleId": "d663fc84-5c37-43d1-a537-793feffb7667",
                "id": "e3370508-a541-4b9c-b83f-3bad33dcca4c"
            }
        ],
        "startDate": "2020-08-03T12:25:08Z",
        "numOfSubmissions": 0,
        "numOfRegistrants": 39,
        "endDate": "2020-08-24T15:00:00Z",
        "currentPhaseNames": [
            "Registration",
            "Checkpoint Submission",
            "Submission"
        ],
        "registrationStartDate": "2020-08-03T12:25:08Z",
        "registrationEndDate": "2020-08-05T12:24:40Z",
        "submissionStartDate": "2020-08-03T12:31:47Z",
        "submissionEndDate": "2020-08-05T12:24:40Z",
        "prizeSets": [
            {
                "prizes": [
                    {
                        "type": "USD",
                        "value": 1200
                    },
                    {
                        "type": "USD",
                        "value": 600
                    }
                ],
                "description": "Challenge Prizes",
                "type": "placement"
            },
            {
                "prizes": [
                    {
                        "type": "USD",
                        "value": 100
                    },
                    {
                        "type": "USD",
                        "value": 100
                    },
                    {
                        "type": "USD",
                        "value": 100
                    },
                    {
                        "type": "USD",
                        "value": 100
                    },
                    {
                        "type": "USD",
                        "value": 100
                    }
                ],
                "description": "Checkpoint Prizes",
                "type": "checkpoint"
            }
        ],
        "tags": [],
        "groups": [],
        "winners": [],
        "metadata": [
            {
                "name": "fileTypes",
                "value": "[\"Layered PSD files created in Adobe Photoshop or similar\",\"AI files created in Adobe Illustrator or similar\",\"Sketch\",\"Adobe XD\"]"
            },
            {
                "name": "allowStockArt",
                "value": "true"
            }
        ],
        "events": [
            {
                "name": "2021 Topcoder(R) Open",
                "id": 3453,
                "key": "tco21"
            }
        ],
        "numOfCheckpointSubmissions": 3
    }

SathyaJayabal · 2020-08-06T03:03:26Z

cc @sushilshinde

crazyk07 · 2020-08-06T07:40:15Z

Contest https://www.topcoder.com/challenges/30136116 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

crazyk07 · 2020-08-06T07:40:21Z

Contest https://www.topcoder.com/challenges/30136116 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

…submission count

narekcat · 2020-08-06T10:36:31Z

@sushilshinde @SathyaJayabal I have fixed this issue, see pull request #4719. But there is a challenge for which back end does not return property numOfCheckpointSubmissions, for example 'Telco - Enterprise Customer Portal Web App Design Concepts Challenge'.

SathyaJayabal · 2020-08-07T05:18:48Z

@rootelement ,
https://beta-community-app.topcoder.com/challenges/84a43633-3002-45d0-9742-06311d2c35d9
This challenge has checkpoint submissions, but does not return the numOfCheckpointSubmissions

SathyaJayabal · 2020-08-13T06:41:15Z

@narekcat , this issue still exists.
Note:test for any design challenge in checkpoint submission phase
example:
https://www.topcoder.com/challenges/30136817
https://staging-community-app.topcoder.com/challenges/ae7f8a3f-d28b-4743-ac0f-21e15b9f4891

narekcat · 2020-08-13T07:16:46Z

@SathyaJayabal I have tested on my local machine and it works as expected. I'll check it again and replay.

SathyaJayabal · 2020-08-13T07:21:26Z

@narekcat , maybe you tested for the previous example, which now has moved on to final submission phase. Please test now with the current example.
Note: We are using staging environment now for testing these fixes
https://www.topcoder.com/challenges/30136817
https://staging-community-app.topcoder.com/challenges/ae7f8a3f-d28b-4743-ac0f-21e15b9f4891

narekcat · 2020-08-13T07:30:25Z

@SathyaJayabal Ok.

narekcat · 2020-08-13T08:35:12Z

@SathyaJayabal I can't open challenges mentioned above. I have tested for other challenges and it works as expected. It says challenge does not exists:

SathyaJayabal · 2020-08-13T08:43:15Z

@narekcat , please give your handle.

narekcat · 2020-08-13T08:53:23Z

@SathyaJayabal My handle is Narekvar90.

SathyaJayabal · 2020-08-13T09:27:30Z

@narekcat , can you test now. You should have access to that challenge.

narekcat · 2020-08-13T09:27:55Z

@SathyaJayabal Ok, thanks.

narekcat · 2020-08-13T09:53:07Z

@SathyaJayabal I have tested in my local machine and it works, see screen shot below. I have checked and find out that my latest changes does not merged into branch integration-v5-challenge-api. I'll create new pull request.

narekcat · 2020-08-13T09:54:10Z

Here is pull request #4751

narekcat · 2020-08-13T10:02:45Z

Also you can see that back end returns zero in field 'numOfSubmissions' and two in field 'numOfCheckpointSubmissions'.

SathyaJayabal · 2020-08-13T10:35:55Z

Also you can see that back end returns zero in field 'numOfSubmissions' and two in field 'numOfCheckpointSubmissions'.

@narekcat , Yes right, so we should have 0+2 = 2.
Any questions?

narekcat · 2020-08-13T10:43:00Z

@SathyaJayabal @sushilshinde This is my code https://github.com/narekcat/community-app/blob/issue-4681/src/shared/components/challenge-detail/Header/TabSelector/index.jsx#L37
And this is code in branch integration-v5-challenge-api https://github.com/topcoder-platform/community-app/blob/integration-v5-challenge-api/src/shared/components/challenge-detail/Header/TabSelector/index.jsx#L36
There aren't my latest changes on branch integration-v5-challenge-api and that is because it does not working as expected.

SathyaJayabal · 2020-08-13T10:46:47Z

@SathyaJayabal @sushilshinde This is my code https://github.com/narekcat/community-app/blob/issue-4681/src/shared/components/challenge-detail/Header/TabSelector/index.jsx#L37
And this is code in branch integration-v5-challenge-api https://github.com/topcoder-platform/community-app/blob/integration-v5-challenge-api/src/shared/components/challenge-detail/Header/TabSelector/index.jsx#L36
There aren't my latest changes on branch integration-v5-challenge-api and that is because it does not working as expected.

I think @sushilshinde reverted the fix after I tested it.

narekcat · 2020-08-13T10:49:45Z

@SathyaJayabal @sushilshinde I have created new pull request, please merge it #4751.

SathyaJayabal · 2020-08-14T11:59:01Z

verified on beta(code freeze branch)

crazyk07 · 2020-08-17T07:08:04Z

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30136116

This is an automated message for crazyk via Topcoder X

SathyaJayabal added Challenge Listing P2 Important (resolve within 3 days) Challenge Details Screen Beta Env Environment v5-intgration-sub-code labels Jul 24, 2020

sushilshinde assigned callmekatootie and rootelement Jul 27, 2020

SathyaJayabal unassigned callmekatootie Jul 31, 2020

SathyaJayabal changed the title ~~Submission count mismatch for design contests~~ Submission count does not include checkpoint submissions Aug 5, 2020

Oanh-and-only-Oanh added P1 Urgent (resolve within 24 hours) and removed P2 Important (resolve within 3 days) labels Aug 5, 2020

SathyaJayabal added the Must-fix-before-v5-release label Aug 6, 2020

sushilshinde changed the title ~~Submission count does not include checkpoint submissions~~ [$50]Submission count does not include checkpoint submissions Aug 6, 2020

sushilshinde unassigned rootelement Aug 6, 2020

sushilshinde added the tcx_OpenForPickup label Aug 6, 2020

sushilshinde assigned narekcat Aug 6, 2020

crazyk07 added tcx_Assigned and removed tcx_OpenForPickup labels Aug 6, 2020

narekcat added a commit to narekcat/community-app that referenced this issue Aug 6, 2020

fix: for issue topcoder-platform#4681, add checkpoint submissions to …

ea9b076

…submission count

narekcat added the tcx_ReadyForReview label Aug 6, 2020

SathyaJayabal added this to the V5 Challenge API v1.2 milestone Aug 13, 2020

mtwomey pushed a commit that referenced this issue Aug 14, 2020

fix: for issue #4681

5c2aff6

SathyaJayabal added QA Pass Must-fix-before-v5-release and removed tcx_Feedback labels Aug 14, 2020

SathyaJayabal added the SUSHIL: codefreeze fix label Aug 16, 2020

sushilshinde added the tcx_FixAccepted label Aug 17, 2020

SathyaJayabal closed this as completed Aug 17, 2020

crazyk07 added the tcx_Assigned label Aug 17, 2020

crazyk07 added the tcx_Paid label Aug 17, 2020

SathyaJayabal removed this from the V5 Challenge API v1.2 milestone Aug 17, 2020

narekcat mentioned this issue Sep 17, 2020

[$60] Challenge Details : Incorrect checkpoint/final submission counts for design contest #4256

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$70]Submission count does not include checkpoint submissions #4681

[$70]Submission count does not include checkpoint submissions #4681

SathyaJayabal commented Jul 24, 2020

SathyaJayabal commented Jul 24, 2020 •

edited

Loading

rootelement commented Jul 28, 2020

SathyaJayabal commented Jul 30, 2020

SathyaJayabal commented Aug 5, 2020

rootelement commented Aug 5, 2020

SathyaJayabal commented Aug 6, 2020

crazyk07 commented Aug 6, 2020

crazyk07 commented Aug 6, 2020

narekcat commented Aug 6, 2020

SathyaJayabal commented Aug 7, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020 •

edited

Loading

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 14, 2020

crazyk07 commented Aug 17, 2020

[$70]Submission count does not include checkpoint submissions #4681

[$70]Submission count does not include checkpoint submissions #4681

Comments

SathyaJayabal commented Jul 24, 2020

SathyaJayabal commented Jul 24, 2020 • edited Loading

rootelement commented Jul 28, 2020

SathyaJayabal commented Jul 30, 2020

SathyaJayabal commented Aug 5, 2020

rootelement commented Aug 5, 2020

SathyaJayabal commented Aug 6, 2020

crazyk07 commented Aug 6, 2020

crazyk07 commented Aug 6, 2020

narekcat commented Aug 6, 2020

SathyaJayabal commented Aug 7, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020 • edited Loading

narekcat commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 13, 2020

narekcat commented Aug 13, 2020

SathyaJayabal commented Aug 14, 2020

crazyk07 commented Aug 17, 2020

SathyaJayabal commented Jul 24, 2020 •

edited

Loading

narekcat commented Aug 13, 2020 •

edited

Loading