Skip to content

Thrive updates #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Jul 23, 2020 · 6 comments
Closed

Thrive updates #4679

kkartunov opened this issue Jul 23, 2020 · 6 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Milestone
v0.38.0

Comments

@kkartunov
Copy link
Collaborator

In scope:
@kkartunov kkartunov self-assigned this Jul 23, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Jul 23, 2020
@Dara-K
Copy link

Dara-K commented Jul 25, 2020

Note: the date should always be bottom aligned in the same position @kkartunov

kkartunov added a commit that referenced this issue Jul 27, 2020
@kkartunov
Updates #4679
94c6cad
kkartunov added a commit that referenced this issue Jul 30, 2020
@kkartunov
Share icons Thrive #4679
8c6ea7a
@SathyaJayabal
Copy link
Collaborator

@kkartunov, SRM Editorials still have a banner
Screenshot 2020-08-03 at 10 47 00 AM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Aug 3, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal we will update them in Contentful soon. The functionality for articles without a banner is included in this ticket so we are good about it. Thanks!

@kkartunov kkartunov mentioned this issue Aug 3, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

Verified on dev

  1. no default avatar when member avatar is missing - https://marvelapp.com/prototype/1hei31bg/screen/71426378/handoff
  2. changed the. title of the cards to be smaller : https://marvelapp.com/prototype/1hei31bg/screen/71426374/handoff
  3. blob image for the articles on Thrive - https://marvelapp.com/prototype/1hei31bg/screen/60646916/handoff
  4. for the SRM Editorials we talked of using no banner: https://marvelapp.com/prototype/1hei31bg/screen/71426378/handoff
  5. For the author name and role, please use # 2a2a2a color
  6. For author name and role, let's use 14px size as per design
  7. Social media icons: let's. update to the gray ones

Screenshot 2020-08-03 at 12 43 38 PM

Screenshot 2020-08-03 at 12 46 01 PM

Screenshot 2020-08-03 at 12 42 43 PM

Note: Images for all SRMs will be updated from Contentful soon.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Aug 3, 2020
@SathyaJayabal SathyaJayabal added this to the v0.38.0 milestone Aug 3, 2020
@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env labels Aug 3, 2020
@SathyaJayabal
Copy link
Collaborator

Verified on beta
Screenshot 2020-08-03 at 3 42 04 PM
Screenshot 2020-08-03 at 3 43 42 PM
Screenshot 2020-08-03 at 3 43 58 PM

Note: Images for all SRMs will be updated from Contentful soon.

@kkartunov kkartunov mentioned this issue Aug 3, 2020
Merged
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Aug 4, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-08-04 at 3 13 36 PM
Screenshot 2020-08-04 at 3 13 52 PM
Screenshot 2020-08-04 at 3 14 09 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.38.0
Development

No branches or pull requests
3 participants
@kkartunov @Dara-K @SathyaJayabal