Skip to content

Job Description overview #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oanh-and-only-Oanh opened this issue Jul 20, 2020 · 40 comments
Open

Job Description overview #4659

Oanh-and-only-Oanh opened this issue Jul 20, 2020 · 40 comments
Assignees
Labels
Member Profiles New feature On hold QA Fail QA verification on Dev has failed. Assignee to redo the fix.

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Jul 20, 2020

build front-end to allow members to input data for job descriptions/bullet points

@Oanh-and-only-Oanh
Copy link
Author

@Dara-K , can you help do a quick mock up of front-end design of what this would look like to hand over to dev?

@Oanh-and-only-Oanh
Copy link
Author

@skyhit
Copy link
Contributor

skyhit commented Sep 9, 2020

@Oanh-and-only-Oanh how are we going to save the data, through APIs? are they ready?

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: By 9/24/2020, Release by 10/1/2020 Sep 10, 2020
@Oanh-and-only-Oanh
Copy link
Author

The api is not ready. Working on this now.

@Oanh-and-only-Oanh
Copy link
Author

@urwithat, can you help add the ability to store this new data field into the member API?

@urwithat
Copy link
Contributor

@Oanh-and-only-Oanh - we have the work traits endpoint exposed already. The new attributes can be passed to the same endpoint.
An issue might arise while reading old records in our data store that don't have jobDescription, achievements & technologies attributes, that can be easily handled on the front end.

Sample CURL for fetching:
curl --location --request GET 'https://api.topcoder-dev.com/v5/members/upbeat/traits?traitIds=work'
--header 'Authorization: Bearer token'

Sample CURL for creating:
curl --location --request POST 'https://api.topcoder-dev.com/v5/members/upbeat/traits'
--header 'Authorization: Bearer token'
--header 'Content-Type: application/json'
--data-raw '[
{
"categoryName": "Work",
"traitId": "work",
"traits": {
"data": [
{
"company": "Company 1",
"industry": "Industry 1",
"position": "Position 1",
"cityTown": "City Town 1",
"timePeriodFrom": "2017-11-16T06:30:00.000Z",
"timePeriodTo": "2020-05-01T12:00:00.000Z",
"working": false,
"jobDescription": "jobDescription 1",
"achievements": "achievements 1",
"technologies": "technologies 1"
}
]
}
}
]'

@skyhit
Copy link
Contributor

skyhit commented Sep 23, 2020

@Oanh-and-only-Oanh Can you provide the exported svg icons for the editor toolbar's buttons?

@Oanh-and-only-Oanh
Copy link
Author

@Dara-K, can you provide requested svg icons?

@luizrrodrigues
Copy link
Collaborator

@skyhit Added feedback to both PRs.

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: Release by 10/1/2020, by 10/15/2020 Sep 29, 2020
@luizrrodrigues
Copy link
Collaborator

@skyhit community-app PR looks good.

topcoder-react-lib PR not fixed yet.
topcoder-platform/topcoder-react-lib#261

@luizrrodrigues
Copy link
Collaborator

@skyhit Any status on this one?

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues @skyhit , verified.
Screenshot 2020-11-09 at 9 27 09 PM

@SathyaJayabal
Copy link
Collaborator

verified
Screenshot 2020-11-10 at 1 42 30 PM

@SathyaJayabal SathyaJayabal added QA Pass in Staging QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed QA Pass QA Pass in Staging labels Nov 10, 2020
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 10, 2020

@luizrrodrigues , looks like in prod api call is to
https://api.topcoder.com/v3/members/picachui/traits and staging is
https://api.topcoder.com/v5/members/picachui/traits

users profile details are not getting displayed on staging and the v5 api call is failing
Screenshot 2020-11-10 at 3 12 33 PM
Screenshot 2020-11-10 at 3 12 37 PM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Here V5 Traits Loading, but data no consistence:
image

@skyhit
Copy link
Contributor

skyhit commented Nov 10, 2020

@luizrrodrigues @SathyaJayabal so we should adapt for V5 API? and does V5 API support this?

@SathyaJayabal
Copy link
Collaborator

@skyhit , yes. @luizrrodrigues this may need api updates too? Looks like data returned by the v3 and v5 apis for the same user is different. @skyhit you will need to coordinate with @urwithat for api related updates.

@Oanh-and-only-Oanh
Copy link
Author

@urwithat @skyhit, what's the status on this?

@luizrrodrigues
Copy link
Collaborator

@skyhit I think we need just v3 to traits for now, like existing in Prod.

@urwithat
Copy link
Contributor

@skyhit - Use the member v5 microservices.
@SathyaJayabal - The traits data stored for your member seem to have an issue, have you done any manual changes in any data store or executed any create / update member curl query.
I've synced your member's data, its working now. Please check and close this issue.

@SathyaJayabal
Copy link
Collaborator

@urwithat , I did not do anything to my data other than updation through the community app. @luizrrodrigues also had the same issues. Is it possible to check for some other users too.

@urwithat
Copy link
Contributor

@SathyaJayabal - Have checked for a couple of other members, seems to be fine. Let me know if you find any other members with such an issue.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 25, 2020

@luizrrodrigues , let's deploy this and test, better to use staging.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal @urwithat Deployed to Stag env.

image

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues @skyhit , i don't see an error for the traits api call now. But my profile info for basic details is not getting populated. Maybe because the data format is diff between v3 and v5.
Screenshot 2020-11-25 at 3 24 24 PM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Is same issue in screen above, v5 missing some data.

@luizrrodrigues
Copy link
Collaborator

@urwithat @skyhit Any update on this one? Please let me know if I can use Stag env. (I need to deploy a hotfix to QA)

@luizrrodrigues
Copy link
Collaborator

We're moving this issue to Backlog for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Member Profiles New feature On hold QA Fail QA verification on Dev has failed. Assignee to redo the fix.
Projects
None yet
Development

No branches or pull requests

5 participants