Skip to content

[$50]Subcommunity filter does not include private groups #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jul 16, 2020 · 16 comments
Closed

[$50]Subcommunity filter does not include private groups #4650

SathyaJayabal opened this issue Jul 16, 2020 · 16 comments

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jul 16, 2020

Subcommunity filter does not include private groups
https://www.topcoder.com/challenges?
https://beta-community-app.topcoder.com/challenges?

cc @lakshmiathreya @Oanh-and-only-Oanh @sushilshinde

Screenshot 2020-07-16 at 10 19 56 AM

Screenshot 2020-07-16 at 10 20 39 AM

@SathyaJayabal SathyaJayabal added Challenge Listing P2 Important (resolve within 3 days) Beta Env Environment v5-intgration-sub-code labels Jul 16, 2020
@sushilshinde sushilshinde changed the title Subcommunity filter does not include private groups [$50]Subcommunity filter does not include private groups Jul 18, 2020
@sushilshinde sushilshinde changed the title [$50]Subcommunity filter does not include private groups Subcommunity filter does not include private groups Jul 18, 2020
@sushilshinde sushilshinde changed the title Subcommunity filter does not include private groups [$50]Subcommunity filter does not include private groups Jul 18, 2020
@crazyk07
Copy link

[500]: Challenge for the updated issue 4650 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133391 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

@narekcat any updates?

@narekcat
Copy link
Contributor

@sushilshinde I am working on it. I will finish in nexy six hours.

@narekcat
Copy link
Contributor

@sushilshinde I think the problem is with back-end. This url doesn't return the "TopGear Community" private community.

@narekcat narekcat added the Need clarification Need clarification to proceed fixing the issue further label Jul 20, 2020
@sushilshinde
Copy link
Collaborator

@narekcat it's a proxy call to groups API.

@luizrrodrigues we did use direct call to groups API with user token?

@luizrrodrigues
Copy link
Collaborator

@sushilshinde

  • To get user groups this is done with the user token.
  • To get all groups (used in filter and community sub-pages) this is done via m2m

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , filter also only shows the users groups. for example only a topgear member can see the topgear option in the filter dropdown.
This is the behaviour in prod.

cc @sushilshinde

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I'm testing with TonyJ user, this user is member from TopGear Community but this not showing in filters.

Looks like filter are loaded from here: https://github.com/topcoder-platform/community-app/blob/develop/src/server/tc-communities/index.js
This load metadata from JSON files, but look like TopGear not included on this.

@sushilshinde We have a good reason to follow this way instead call data directly from API?

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , this was working previously. see screenshot in the below issue- We only had trouble with the filters not returning the group's challenges.
#4575

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Need to call challenges with Group UUID, not with legacyId. I'll comment in #4575

@luizrrodrigues
Copy link
Collaborator

@sushilshinde
Copy link
Collaborator

Thank @luizrrodrigues

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133391 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

sushilshinde added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Jul 24, 2020
sushilshinde added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Jul 27, 2020
@SathyaJayabal SathyaJayabal added QA Pass and removed Merged for QA Ready for QA Need clarification Need clarification to proceed fixing the issue further labels Jul 27, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on beta
Screenshot 2020-07-27 at 10 38 16 AM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30133391

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants