Skip to content

[$40]Register button active and submit button disabled even after user is registered #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jul 14, 2020 · 12 comments

Comments

@SathyaJayabal
Copy link
Collaborator

@sushilshinde
Copy link
Collaborator

@luizrrodrigues dint we fix this?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jul 15, 2020

@sushilshinde Yes, this was fixed.

@SathyaJayabal Looks like working well here:
https://beta-community-app.topcoder.com/challenges/a64f4d95-0074-4c1a-96f1-91fa4320beca?tab=registrants
and
https://beta-community-app.topcoder.com/challenges/339964ff-69fe-42f4-b97f-1f67e8561c75?tab=registrants

Groups test challenge, I can't test this one because I haven't access to the group.

image

image

@SathyaJayabal SathyaJayabal added P0 Critical (resolve within 4 hours) and removed P1 Urgent (resolve within 24 hours) labels Jul 15, 2020
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 15, 2020

@luizrrodrigues , This issue is not consistent across users/challenges. I still see the blue register button for this challenge even though I am regsitered
https://beta-community-app.topcoder.com/challenges/a64f4d95-0074-4c1a-96f1-91fa4320beca?tab=registrants
user: picachui
Screenshot 2020-07-15 at 10 15 21 AM

You can replicate the issue with following user
user: CustomerUser/appirio123
Challenge: https://beta-community-app.topcoder.com/challenges/0ea10b6f-c089-457b-8c08-b01be006b25e
V4 Prod link for comparison
https://www.topcoder.com/challenges/30131098
Screenshot 2020-07-15 at 10 34 42 AM

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jul 15, 2020

@SathyaJayabal Thanks for give more examples.

@sushilshinde I have found the issue, is about miss match var type, userId in auth return is String type and memberId in registrants is Number type.

I think this need be fixed in API to keep data type consistent, but if you want we handle this in FE, I'll push a hot fix to this one.

You can check inconsistent data can be checked here:
https://api.topcoder.com/v5/resources?challengeId=3214d19f-63bd-40e9-a19f-f5c9908ab3d2&roleId=732339e7-8e30-49d7-9198-cccf9451e221

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde sushilshinde changed the title Register button active and submit button disabled even after user is registered [$40]Register button active and submit button disabled even after user is registered Jul 15, 2020
@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 15, 2020

@luizrrodrigues please PR fix from FE

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133108 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30133108 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@sushilshinde PR is ready: topcoder-platform/topcoder-react-lib#208

@SathyaJayabal
Copy link
Collaborator Author

verified on Beta
Screenshot 2020-07-16 at 9 56 19 AM
Screenshot 2020-07-16 at 9 56 29 AM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30133108

This is an automated message for crazyk via Topcoder X

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , tested this again. Looks good.
Screenshot 2020-07-17 at 1 02 02 PM
Screenshot 2020-07-17 at 1 10 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants