Skip to content

[$60]Registrants tab : Registrants table issues #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 17, 2020 · 24 comments
Closed

[$60]Registrants tab : Registrants table issues #4546

SathyaJayabal opened this issue Jun 17, 2020 · 24 comments

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jun 17, 2020

examples:
V5 URL: https://beta-community-app.topcoder.com/challenges/ad26ade8-aa6f-4623-bb65-ac510c70bef3?tab=registrants
V4 URL: https://www.topcoder.com/challenges/30128601?tab=registrants
Registration Date Column:

  1. By default the registrants table must be sorted by registration date (earliest to latest). The registrants table is not sorted. Also clicking on the sort icon for the registration date does not work.
  2. Registration Date timezone is different in the V4 and V5. There is a difference of 4 hours between the two
    Submission Date Column:
  3. Submission date data is not displayed.
    Rating Column:
  4. For Bug Hunt challenges rating column is not displayed in V4, but is displayed in V5.

Screenshot 2020-06-17 at 8 57 34 AM

![Uploading Screenshot 2020-06-17 at 9.01.46 AM.png…]

V5 URL:https://beta-community-app.topcoder.com/challenges/a9a1594c-2517-4a84-8a62-58e709d89b5e?tab=registrants
V4 URL:https://www.topcoder.com/challenges/30128253?tab=registrants
Rating / Handle Columns:
5. The rating colour is not reflected for handle and rating - tracked here
#4530
6. If the user is not rated, then a "-" must be displayed instead of "0"
Screenshot 2020-06-17 at 9 33 08 AM
Screenshot 2020-06-17 at 9 33 28 AM

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde @lakshmiathreya FYI: the rating for some users in the table mismatches with prod. But the prod rating is wrong. V5 displays the correct rating.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 17, 2020

@Oanh-and-only-Oanh for point # 4 above, is there any specific reason to not show the rating column for Bug Hunts challenges, in production ? The same issue is also applicable for F2Fs.

@Oanh-and-only-Oanh
Copy link

@sushilshinde, we can show ratings for bug hunts.

@sushilshinde sushilshinde changed the title Registrants tab : Registrants table issues [$50]Registrants tab : Registrants table issues Jun 18, 2020
@sushilshinde sushilshinde changed the title [$50]Registrants tab : Registrants table issues [$60]Registrants tab : Registrants table issues Jun 18, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30130319 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30130319 has been updated - it has been assigned to nursoltan-s.

This is an automated message for crazyk via Topcoder X

@nursoltan-s
Copy link
Collaborator

image

Now, resources api returning submissionDate correctly.

@nursoltan-s
Copy link
Collaborator

PR

@nursoltan-s
Copy link
Collaborator

For timezone issues, Is adding 4 hours to date solves problem? Or should i set timezone to moment() call? If so which timezone should it be?

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 22, 2020

@SathyaJayabal please clarify this

@nursoltan-s something like this moment().local().format no harcoding

@rootelement your opinion?

@sushilshinde sushilshinde added the Need clarification Need clarification to proceed fixing the issue further label Jun 22, 2020
@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , I don't think we should be adding 4 hours in the front-end.

@sushilshinde
Copy link
Collaborator

@sushilshinde , I don't think we should be adding 4 hours in the front-end.

Yes, no hard coding.
@nursoltan-s display local time

@nursoltan-s
Copy link
Collaborator

@sushilshinde @SathyaJayabal
Thanks for the feedback.

Changed timezone calculation to moment().local().format

@nursoltan-s nursoltan-s removed the Need clarification Need clarification to proceed fixing the issue further label Jun 22, 2020
@sushilshinde
Copy link
Collaborator

dont test on beta yet

@lakshmiathreya
Copy link

  1. Registration Date is sorted earliest to latest by default. Sorting on Registration Date is working as expected.
  2. Timezone comparison with v4 is not possible in Test.
  3. Submission Date is not consistently present.
  4. Rating is not present.
  5. Rating color is shown.
  6. No rating so cant test this.

Screenshot 2020-06-22 at 5 08 50 PM

Screenshot 2020-06-22 at 5 09 54 PM

Screenshot 2020-06-22 at 5 10 02 PM

@lakshmiathreya
Copy link

Screenshot 2020-06-22 at 5 12 06 PM

@lakshmiathreya lakshmiathreya removed the Beta Env Environment label Jun 22, 2020
@lakshmiathreya lakshmiathreya added Test Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Jun 22, 2020
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 22, 2020

@nursoltan-s ,

  1. please use colours mentioned here
    Member Profile : member handle colour does not match the exact rating colour #4289 (comment)
  2. No need for rating colour for design contests
    see example: https://www.topcoder.com/challenges/30129302?tab=registrants
  3. Rating column : according to this comment, no needed to remove rating column for BH and F2F contests.

@SathyaJayabal
Copy link
Collaborator Author

@nursoltan-s
4. Time difference is still there between V4 and V5
Screenshot 2020-06-23 at 10 57 09 AM
Screenshot 2020-06-23 at 10 57 13 AM

nursoltan-s added a commit to nursoltan-s/community-app that referenced this issue Jun 23, 2020
@nursoltan-s
Copy link
Collaborator

  1. Changed color codes of user
  2. Only Design challenges doesn't have rating column
  3. Removed design contest users' color.

PR

@nursoltan-s
Copy link
Collaborator

@SathyaJayabal @sushilshinde
time calculation is based on local time. Does it mean beta and test environment have different time settings?

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 23, 2020

@nursoltan-s , lets track the timezone issue separately.

@nursoltan-s
Copy link
Collaborator

Okay. I created PR for above comments.

@nursoltan-s
Copy link
Collaborator

  1. Changed color codes of user
  2. Only Design challenges doesn't have rating column
  3. Removed design contest users' color.

PR

Pr

@nursoltan-s nursoltan-s added tcx_ReadyForReview and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jun 23, 2020
@sushilshinde sushilshinde added Merged for QA Ready for QA and removed tcx_ReadyForReview P2 Important (resolve within 3 days) labels Jun 23, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on beta
Screenshot 2020-06-23 at 6 24 57 PM
Screenshot 2020-06-23 at 6 25 14 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30130319

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants