[$40]Challenge Details: Checkpoints tab not displayed

[SathyaJayabal]

Challenge Details: Checkpoints tab not displayed for design challenges with checkpoint phase
Examples:
Dev backend:
V5 URL: https://test-community-app.topcoder-dev.com/challenges/4bccb4bb-b0a1-4046-8da0-69e4027fbc1a
V4 URL: https://qa-community-app.topcoder-dev.com/challenges/30021775
Prod backend
V5 URL:https://beta-community-app.topcoder.com/challenges/6b29e50f-fe49-47a8-a949-f96a00c22448
V4 URL: https://www.topcoder.com/challenges/30126386

[crazyk07]

Contest https://www.topcoder.com/challenges/30129402 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30129402 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

[PrakashDurlabhji]

@sushilshinde I anaylzed well.

there is no checkpoints array present in v5 urls

https://api.topcoder.com/v5/challenges/6b29e50f-fe49-47a8-a949-f96a00c22448?
http://api.topcoder-dev.com/v5/challenges?legacyId=30021775

whereas available in v4
http://api.topcoder-dev.com/v4/challenges/30021775

hence it fails because a check is applied at checkpoints tab

[sushilshinde]

ok so this is an API issue?

[rootelement]

This is not an api issue. You will need to call to the submissions api with the submissionPhaseId:
https://api.topcoder-dev.com/v5/submissions?submissionPhaseId=775498

[
   {
      "updatedBy":"ghoster",
      "created":"2020-06-09T06:30:34.809Z",
      "legacySubmissionId":209335,
      "isFileSubmission":false,
      "type":"Contest Submission",
      "url":"https://s3.amazonaws.com/topcoder-dev-submissions/9146ff17-7a4d-41f3-812b-7471bd692fb0.zip",
      "challengeId":30056709,
      "createdBy":"ghoster",
      "review":[
         {
            "score":100,
            "updatedBy":"MeaSS8yPG4VIer4XalVqOAYhnCNecGfN@clients",
            "reviewerId":"36f37d48-77a8-413f-8bed-e39f154f1301",
            "submissionId":"9146ff17-7a4d-41f3-812b-7471bd692fb0",
            "createdBy":"MeaSS8yPG4VIer4XalVqOAYhnCNecGfN@clients",
            "created":"2020-06-09T06:30:49.191Z",
            "scoreCardId":101761150,
            "typeId":"d96d5f17-5884-47b8-bfea-bddf066e451f",
            "id":"8a2ed5aa-37e2-4059-a449-7d5eab4f1d70",
            "updated":"2020-06-09T06:30:49.191Z",
            "status":"completed"
         },
         {
            "score":100,
            "updatedBy":"maE2maBSv9fRVHjSlC31LFZSq6VhhZqC@clients",
            "reviewerId":"aec9a3d6-50cd-46aa-a462-fcb1ccb55de9",
            "submissionId":"9146ff17-7a4d-41f3-812b-7471bd692fb0",
            "createdBy":"maE2maBSv9fRVHjSlC31LFZSq6VhhZqC@clients",
            "created":"2020-06-09T06:30:40.134Z",
            "scoreCardId":30001850,
            "typeId":"68c5a381-c8ab-48af-92a7-7a869a4ee6c3",
            "id":"d1c2b66c-9feb-4ff4-be6b-850225f100c7",
            "updated":"2020-06-09T06:30:40.134Z",
            "status":"completed"
         }
      ],
      "id":"9146ff17-7a4d-41f3-812b-7471bd692fb0",
      "submissionPhaseId":775498,
      "updated":"2020-06-09T06:30:34.809Z",
      "fileType":"zip",
      "memberId":10098915
   }
]

[PrakashDurlabhji]

@rootelement @sushilshinde I guess there is some misunderstanding from your side or I am not able interpret it. Let me explain my best till now.

1. Kindly go to https://www.topcoder.com/challenges/30126386?tab=checkpoints and see the checkpoints page.
2. Now go to http://api.topcoder.com/v4/challenges/30126386 you would checkpoints array.
3. Now the content of checkpoints array is

			"checkpoints": [{
				"submitter": "ndondo_",
				"submissionId": 375068,
				"submissionTime": "2020-05-27T01:20:44.000Z"
			}]

4. "Feedback 375068 " can be seen on checkpoints tab.
5. so checkpoints array is needed.
6. Now as @rootelement mentions in above comment to hit submission api, but from where to get submissionphaseId?
7. do I need to take it out from phase array having submission object, from there I need to pick the phaseId field and hit the api as you said?
8. Even If I do that then the response pasted by @rootelement , how to match it? I can see submissionId can be matched,but what about "submitter"?
9. Also I feel submitter field has least importance when i visit https://www.topcoder.com/challenges/30126386?tab=checkpoints because only submissionId can be seen on page.
10. then by the response of @rootelement , we will display "Feedback 9146ff17-7a4d-41f3-812b-7471bd692fb0" are we going to display something like this?

I am totally confused, may be I am missing something, Any extra doc which is shared internally at your side for this submission phase id topic would help me? I can read that then.

Waiting for some more clarification

[rootelement]

Yes, if this is the case, those checkpoints are being referred to by their ID. The new IDs are UUIDs. We can treat it like Github where a hash is referred to by the first chunk of the hash. So in that case, show "Feedback 9146ff17", splitting it on the first -

I'm not sure that's the best solution, but that's the similar solution to what we have now. We could also look up the handles for the checkpoints, and show that, but I'm not sure that's something we'd want to show on that page.

[PrakashDurlabhji]

@sushilshinde PR #4551

[SathyaJayabal]

Checkpoint tab not yet displayed

[SathyaJayabal]

@sushilshinde @PrakashDurlabhji , according to this comment
#4516 (comment)
we should use the submissions api to get the checkpoint details.

But the api call used here is the older V2 call.
https://api.topcoder.com/v2/design/challenges/checkpoint/30127234

@sushilshinde , please confirm if this is the right approach.

[PrakashDurlabhji]

@SathyaJayabal Yes to my best it is right approach, as earlier I messed up in analyzing the flow and I even confused @rootelement I believe.Hence after digging up I came to know flow is simple.

@sushilshinde is aware of flow.

Waiting for confirmation.

[sushilshinde]

@PrakashDurlabhji follow this #4516 (comment)

[PrakashDurlabhji]

@sushilshinde are you sure? because it does not match the relevant data and also till now we were using same v2 call though I am aware we are upgrading.

1. I feel even if we have migrated then we should be using a endpoint similar to /design/checkpoint and pass "ChallengeId"?
2. @rootelement should take a look again at data being received because it nowhere matches the data.

rest I would implement as you say

[SathyaJayabal]

@PrakashDurlabhji , we do not use this call in production. This was used before V4.

[PrakashDurlabhji]

@rootelement @SathyaJayabal
sorry for dragging it long

1. can you please go to https://www.topcoder.com/challenges/30127234?tab=checkpoints
2. data present in checkpoints tab is coming from here https://api.topcoder.com/v2/design/challenges/checkpoint/30127234

can you please correct me if i am wrong? even i am running prod locally and verifying it in few minutes where this call was used in production or not

@rootelement sushil and I are waiting for your confirmation

[SathyaJayabal]

@PrakashDurlabhji , yes you are right, this call is used in prod.

[PrakashDurlabhji]

@SathyaJayabal then I hope my solution is accepted because prod using same api, and also if we wish to move to v5, then I feel same endpoint should be moved to v5, and I still feel @rootelement may have mistaken the endpoint interpretation in hurry.

Hence lets see what are inputs from @rootelement because I myself mistaken the checkpoints array then pasted a huge explanation which was irrelevant and expected root element and messd up everything once again.

[PrakashDurlabhji]

@SathyaJayabal Yes it is used I just confirmed running locally

Request URL: https://api.topcoder.com/v2/design/challenges/checkpoint/30126386
Request Method: GET
Status Code: 200

[PrakashDurlabhji]

@sushilshinde can we close this? @SathyaJayabal

[PrakashDurlabhji]

@SathyaJayabal any updates on this?

[SathyaJayabal]

@PrakashDurlabhji , we are waiting for confirmation from @rootelement before we close it.

[rootelement]

@SathyaJayabal @PrakashDurlabhji @sushilshinde I've reviewed this with @ThomasKranitsas and I think we need to leave this as is for now. We don't have anything in Submissions API to do it, and it's not something that should be added to the challenge response. Please log this on the community app repo as a TechDebt item, and we'll get it in the pipeline for the submissions api or somewhere where it fits better.

[PrakashDurlabhji]

@sushilshinde @rootelement I hope something would be paid for my extensive efforts and explanation.

[SathyaJayabal]

@sushilshinde @PrakashDurlabhji , marking this as pass as per this comment
#4516 (comment)

[SathyaJayabal]

#4591

[crazyk07]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30129402

This is an automated message for crazyk via Topcoder X