Skip to content

[$50]Challenge Details: Challenge Spec is missing for design challenges #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 1, 2020 · 40 comments
Closed

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jun 1, 2020

Challenge Spec is missing in V5 for design challenges
user: not logged in
Contest deadline dates and times do not match with V4 dates and times. The checkpoint review deadline is also missing for design challenges.
V4 URL:https://www.topcoder.com/challenges/30126014
Screenshot 2020-06-01 at 10 40 08 AM

V5 URL:https://beta-community-app.topcoder.com/challenges/fbd47239-43dc-4f50-8d0d-739dfe82191a

Screenshot 2020-06-01 at 10 40 11 AM

@SathyaJayabal SathyaJayabal changed the title Challenge Details: Challenge Spec is missing Challenge Details: Challenge Spec is missing for design challenges Jun 1, 2020
@SathyaJayabal SathyaJayabal added P0 Critical (resolve within 4 hours) and removed P1 Urgent (resolve within 24 hours) labels Jun 1, 2020
@SathyaJayabal
Copy link
Collaborator Author

@rootelement
Copy link
Contributor

@SathyaJayabal
Copy link
Collaborator Author

@rootelement , the below doesn't return the new id for the challenge. So not able to verify if the challenge spec is displayed on the challenge details page.
http://api.topcoder-dev.com/v5/challenges?legacyId=30021358

@SathyaJayabal
Copy link
Collaborator Author

cc @sushilshinde

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 2, 2020

@SathyaJayabal scroll and check metadata object

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , I see the id under metadata, thanks

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , not able to see the challenge spec on the frontend, even though the challenge spec is being returned from the api call
http://api.topcoder-dev.com/v5/challenges/75a9e765-e3e7-4d05-a5f6-94358f52498a

https://test-community-app.topcoder-dev.com/challenges/75a9e765-e3e7-4d05-a5f6-94358f52498a

Screenshot 2020-06-02 at 3 42 33 PM

@sushilshinde
Copy link
Collaborator

That needs front-end fix

@sushilshinde sushilshinde changed the title Challenge Details: Challenge Spec is missing for design challenges [$50]Challenge Details: Challenge Spec is missing for design challenges Jun 2, 2020
@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127638 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127638 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

@PrakashDurlabhji please do not work on this

@PrakashDurlabhji
Copy link
Contributor

PrakashDurlabhji commented Jun 2, 2020

@sushilshinde will it be given to me later? also any more issues opening soon?

@sushilshinde
Copy link
Collaborator

Not today, it will be tomorrow

@rootelement
Copy link
Contributor

This is an artifact of design challenges and dev challenges being separate. Just move this to the bottom after the spec. Do not do any logic to split specifications. No API fix is needed here.

@PrakashDurlabhji
Copy link
Contributor

@SathyaJayabal @sushilshinde as clarified above i will add yellow block at bottom after description.

@rootelement am I correct with understanding?

@rootelement
Copy link
Contributor

Yes, this is as designed

@PrakashDurlabhji
Copy link
Contributor

@sushilshinde new PR #4494

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde @rootelement @PrakashDurlabhji , the formatting is still missing #4450 (comment)

I am reducing the priority as the main issue is resolved.

@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) and removed P0 Critical (resolve within 4 hours) labels Jun 9, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Jun 9, 2020
@PrakashDurlabhji
Copy link
Contributor

@SathyaJayabal @sushilshinde regarding formatting I have least control on it as whatever styles present in description property is being seen and there are inline styles present in it.
will check on it and revert back but can you please send any latest challenge links so that I can verify too. I will checkmyself too

@sushilshinde
Copy link
Collaborator

@SathyaJayabal please close this issue, open new issue for styling with low priority

@SathyaJayabal SathyaJayabal added QA Pass Beta Env Environment and removed Need clarification Need clarification to proceed fixing the issue further labels Jun 10, 2020
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 10, 2020

@sushilshinde , marked this as pass. We can close once the tcx_accepted label is added.
I will create a new issue for styling.

#4510

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde new PR #4494
@sushilshinde , sorry we cant close this yet, We still have to merge the latest pr and verify.

@PrakashDurlabhji
Copy link
Contributor

@sushilshinde @SathyaJayabal here is new PR #4518

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 12, 2020

verified on test and beta
Screenshot 2020-06-12 at 10 14 27 AM
Screenshot 2020-06-12 at 10 14 30 AM
Screenshot 2020-06-12 at 10 14 46 AM
Screenshot 2020-06-12 at 10 15 01 AM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30127638

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants