Skip to content

Update NewsletterSignupForMembers component #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue May 29, 2020 · 2 comments
Closed

Update NewsletterSignupForMembers component #4439

kkartunov opened this issue May 29, 2020 · 2 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Milestone
v0.35.0

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented May 29, 2020 •
edited
Loading

In scope:

  • Make the button hidden for members that are already registered, show only for not yet registered members.
  • add theme parameter to support different button styles
  • Add new parameters to NewsletterSignupForMembers component to support custom texts for its related models.
    • title
    • text
  • update docs

Test: https://community-app.topcoder-dev.com/examples/contentful/contentblock/6Qorcl1qErl8zbDTr82V4q
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label May 29, 2020
@kkartunov kkartunov self-assigned this May 29, 2020
@kkartunov kkartunov changed the title Custom text support in newsletter modal Update NewsletterSignupForMembers component May 29, 2020
kkartunov added a commit that referenced this issue Jun 1, 2020
@kkartunov
Updates for #4439
0055da4
@kkartunov kkartunov reopened this Jul 7, 2020
@SathyaJayabal
Copy link
Collaborator

verified on dev(develop branch)
4439.mov.zip

@SathyaJayabal SathyaJayabal modified the milestones: v0.34.1, v0.34.2 Jul 8, 2020
@kkartunov kkartunov mentioned this issue Jul 8, 2020
Merged
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Dev Env labels Jul 8, 2020
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jul 8, 2020 •
edited
Loading

verified on prod

4439_prod.mov.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.35.0
Development

No branches or pull requests
3 participants
@sushilshinde @kkartunov @SathyaJayabal