[$60]Challenge Details: Eligible events section not displayed

[SathyaJayabal]

V5 URL: https://beta-community-app.topcoder.com/challenges/d9c74629-762f-4464-9753-ebd982c7990f

V4 URL: https://www.topcoder.com/challenges/30106190

[SathyaJayabal]

FYI: This issue was tested on production backend. Please use the given urls to compare
V5 URL: https://beta-community-app.topcoder.com/challenges/d9c74629-762f-4464-9753-ebd982c7990f
V4 URL: https://www.topcoder.com/challenges/30106190

[crazyk07]

Contest https://www.topcoder.com/challenges/30126891 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30126891 has been updated - it has been assigned to sr_jr.

This is an automated message for crazyk via Topcoder X

[srjr19]

@sushilshinde @rootelement can you help how do we get events from challenge-api, I don't see any placeholder on API response for curl -X GET "https://api.topcoder.com/v5/challenges/:challengeId" -H "accept: application/json" ?

[rootelement]

This has to be migrated. Working on adding this to the metadata object. it will be as such:

"metadata": [
 {
  "events": [
   {
      "id": 3446,
      "name": "2016 TopCoder(R) Open",
      "key": "tco16"
   }]
  }
],

*Edited to make the structure an array, as expected

[SathyaJayabal]

@rootelement , I think there is a link also associated with the text

[rootelement]

Not according to the v4 response
https://github.com/appirio-tech/ap-challenge-microservice/blob/dev/src/main/resources/sql/challenge/challenge_details.sql

[rootelement]

it gets id, event_desc, and event_short_desc

[SathyaJayabal]

@rootelement , I see a link also here in this example.
https://www.topcoder.com/challenges/30106190

[rootelement]

That link is built on the frontend, it's not part of the api response

[rootelement]

This is done in dev:
http://api.topcoder-dev.com/v5/challenges?legacyId=30051154

Will run on prod overnight

[sushilshinde]

@simranb86 waiting on PR

[srjr19]

PRs:

• fix for issue #4430 topcoder-react-lib#176
• fix for issue #4430 #4443

[srjr19]

@simranb86 waiting on PR

Sorry I thought I already pushed it, has it ready once received the info. Pushed in PRs now.

[SathyaJayabal]

@sushilshinde , can see the eligible events on dev, but not on prod
example: https://beta-community-app.topcoder.com/challenges/d9c74629-762f-4464-9753-ebd982c7990f
cc @rootelement

[srjr19]

@SathyaJayabal yes, this is data issue, plz make sure you test with challenge which has events in it - try this via postman https://api.topcoder-dev.com/v5/challenges/<challengeId> to see if that challenge has events there in response.

[SathyaJayabal]

@simranb86, on testing after the data migration in dev. I can see the events in the api response, but not in the front end. Can you please take a look.
cc @sushilshinde
https://test-community-app.topcoder-dev.com/challenges/3c56f0ad-5060-443f-990a-94c384ec41d3
http://api.topcoder-dev.com/v5/challenges/3c56f0ad-5060-443f-990a-94c384ec41d3
V4 URL:https://qa-community-app.topcoder-dev.com/challenges/30051173

[srjr19]

@sushilshinde , can see the eligible events on dev, but not on prod
example: https://beta-community-app.topcoder.com/challenges/d9c74629-762f-4464-9753-ebd982c7990f
cc @rootelement

@SathyaJayabal The backend impl was changed, it is re-work to be done here. The metadata was an object but now it has been updated to be an array.

Now I get this

"metadata":[{"events":[{"id":3446,"name":"2016 TopCoder(R) Open","key":"tco16"}]}]

@rootelement can you confirm whether metadata will be array or object as it would mean re-work again, if I change it to be an array now and in future we return object again ?

@sushilshinde FYI ☝️

[rootelement]

I apologize @simranb86 , metadata was always intended to be an array of objects with {type, value}.

See here:
http://api.topcoder-dev.com/v5/challenges/ce01f468-e5cc-4c03-abe6-0e625af94ec1

Events is no different:
http://api.topcoder-dev.com/v5/challenges/3c56f0ad-5060-443f-990a-94c384ec41d3

[srjr19]

I apologize @simranb86 , metadata was always intended to be an array of objects with {type, value}.

See here:
http://api.topcoder-dev.com/v5/challenges/ce01f468-e5cc-4c03-abe6-0e625af94ec1

Events is no different:
http://api.topcoder-dev.com/v5/challenges/3c56f0ad-5060-443f-990a-94c384ec41d3

Thanks @rootelement

@SathyaJayabal @sushilshinde give me like 30 mins, will raise new PR for the changes. Thanks

[sushilshinde]

@simranb86 please link PR

[srjr19]

@simranb86 please link PR

@sushilshinde this is pending for @rootelement to provide a challenge which has events in valid format. I already flagged him on slack and waiting for him to provide one which could be used for development and then can pass to qa to validate it.

[rootelement]

Events is now a first class object:
http://api.topcoder-dev.com/v5/challenges?legacyId=30051173

Also, metadata is {name, value}, not {type, value}
http://api.topcoder-dev.com/v5/challenges?legacyId=30048648

please update accordingly and see my big update in slack for today.

[srjr19]

Events is now a first class object:
http://api.topcoder-dev.com/v5/challenges?legacyId=30051173

Also, metadata is {name, value}, not {type, value}
http://api.topcoder-dev.com/v5/challenges?legacyId=30048648

please update accordingly and see my big update in slack for today.

Thanks @rootelement

@sushilshinde PR for the same topcoder-platform/topcoder-react-lib#180

[sushilshinde]

Thanks @simranb86

[SathyaJayabal]

verified on beta

[crazyk07]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30126891

This is an automated message for crazyk via Topcoder X