Skip to content

[$50]Challenge Listings: Challenge count #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue May 19, 2020 · 23 comments
Closed

[$50]Challenge Listings: Challenge count #4375

SathyaJayabal opened this issue May 19, 2020 · 23 comments

Comments

@SathyaJayabal
Copy link
Collaborator

Only 15 challenges are displayed
Screenshot 2020-05-19 at 6 06 29 PM

@SathyaJayabal SathyaJayabal added Test Env Environment v5-intgration-sub-code P1 Urgent (resolve within 24 hours) labels May 19, 2020
@sushilshinde sushilshinde changed the title Challenge Listings: Challenge count [$50]Challenge Listings: Challenge count May 22, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126384 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126384 has been updated - it has been assigned to thomaskranitsas.

This is an automated message for crazyk via Topcoder X

@SathyaJayabal
Copy link
Collaborator Author

@ThomasKranitsas , can you please provide an ETA for this ticket ?

@ThomasKranitsas
Copy link
Contributor

I was without internet connection yesterday. Will work to provide a solution today

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126384 has been updated - it has been assigned to sr_jr.

This is an automated message for crazyk via Topcoder X

@srjr19
Copy link
Contributor

srjr19 commented May 28, 2020

@SathyaJayabal @sushilshinde what can I use to compare this with? What is expected challenges count here ?

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 Compare with V4 challenge count in production backend as all challenges have been migrated in prod.
V5 : https://beta-community-app.topcoder.com/challenges?
V4 : https://www.topcoder.com/challenges?

@sushilshinde , we can compare with dev backend too once all challenges are migrated in dev. Please let us know when thats done
ref:https://topcoder.slack.com/archives/G012CL5GF71/p1590507667214400

@srjr19
Copy link
Contributor

srjr19 commented May 28, 2020

@simranb86 Compare with V4 challenge count in production backend as all challenges have been migrated in prod.
V5 : https://beta-community-app.topcoder.com/challenges?
V4 : https://www.topcoder.com/challenges?

@sushilshinde , we can compare with dev backend too once all challenges are migrated in dev. Please let us know when thats done
ref:https://topcoder.slack.com/archives/G012CL5GF71/p1590507667214400

@SathyaJayabal so we are saying we only have PROD data on challenges-api being used V5 ? Because if we are adding more challenges in V5 for this integration testing, then results cannot be same.

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 please confirm up with @rootelement about the frequency of the data sync up between the v4 and v5 backends (both on prod and dev)

cc @sushilshinde

@srjr19
Copy link
Contributor

srjr19 commented May 28, 2020

@simranb86 please confirm up with @rootelement about the frequency of the data sync up between the v4 and v5 backends (both on prod and dev)

cc @sushilshinde

@rootelement can you confirm we are not having any other challenges on V5 other than what are coming from V4 else this comparison doesn't sounds right here and its too difficult to do one by one comparison for each challenge being returned between V4 and V5 ?

@srjr19
Copy link
Contributor

srjr19 commented Jun 7, 2020

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 , @sushilshinde We can now see challenges in all the buckets. But there are many issues with the challenges displayed.

  1. Migration issue : MM challenges and some other challenges were not migrated during the last data migration
    MM challenges not migrated in prod backend challenge-api#148
    Migration Issues: Production Backend challenge-api#149

  2. Many completed challenges are displayed in the ongoing and open for registration buckets

Screenshot 2020-06-08 at 11 30 42 AM

  1. Many Ongoing challenges are displayed in the Open for registration bucket

Screenshot 2020-06-08 at 11 36 03 AM

  1. Some of the challenge phases do not match

Screenshot 2020-06-08 at 11 40 39 AM

5. Some challenges have correct bucket and phase, but timeline does not match

Screenshot 2020-06-08 at 11 42 35 AM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Jun 8, 2020
@srjr19
Copy link
Contributor

srjr19 commented Jun 8, 2020

@SathyaJayabal 2/3/4/5 is already covered in separate ticket I guess and they weren't part of this ticket - the main part was to get the numbers in which weren't coming earlier. The challenges are displayed this way due to data as I see from snapshots. The timezone issue I have already highlighted before also to @sushilshinde - need to dig into chat history. This maybe due to different env, hosted differently or migration doing something with dates is my best guess.

Let me know what is to be done as part of this specs clearly plz - @SathyaJayabal @sushilshinde

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , shall we open new issues to address these problems individually?

cc @simranb86

@srjr19
Copy link
Contributor

srjr19 commented Jun 8, 2020

@sushilshinde , shall we open new issues to address these problems individually?

cc @simranb86

@SathyaJayabal that would sound fair to be frank. My board is clean so @sushilshinde can assign them to me once we have them in. Addressing one at a time sounds reasonable, as we need to check API and each such challenge.

But do we have list of challenges or these are just some of them? I think it would be fair to get list of challenges, this way developers can check what V4 and V5 API is returning and then check code if this is code issue or V5 API issue.

I am sure you will agree it is time consuming effort to do this so let's address them with list of challenges to validate to be fair else we go in rounds of Review/QA verification.

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 , what do you mean by list of challenges in your above comment ?

@sushilshinde
Copy link
Collaborator

@SathyaJayabal QA comments aren't related to this particular issue scope.

How is 1 to 5 related to this issue?

Open new issues for each observation.

@srjr19
Copy link
Contributor

srjr19 commented Jun 8, 2020

@simranb86 , what do you mean by list of challenges in your above comment ?

@SathyaJayabal I meant list all challenges which are in wrong bucket when you open new tickets.

BTW as also flagged by @sushilshinde we can move this to QA Pass as the issues are not related to original requirement here.

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 , what do you mean by list of challenges in your above comment ?

@SathyaJayabal I meant list all challenges which are in wrong bucket when you open new tickets.

BTW as also flagged by @sushilshinde we can move this to QA Pass as the issues are not related to original requirement here.

@simranb86 , there are too many to list every challenge. I will give examples for each sub issue and we can go from there. Most cases fixing the example case should fix all similar challenges.

@SathyaJayabal
Copy link
Collaborator Author

Marking this as pass as we now have challenges listed for all buckets. Will track the issues 1-5 with new issues

@SathyaJayabal SathyaJayabal added QA Pass Beta Env Environment and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jun 8, 2020
@srjr19
Copy link
Contributor

srjr19 commented Jun 9, 2020

@Oanh-and-only-Oanh @SathyaJayabal should we close this as it has been in QA Pass since 2 days now ?

@SathyaJayabal
Copy link
Collaborator Author

@simranb86 , was just waiting for @sushilshinde to add the tcx_accepted label, otherwise your payment will not be processed.

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30126384

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants