Skip to content

Update TC Footer to new design #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Apr 2, 2020 · 9 comments
Closed

Update TC Footer to new design #4158

kkartunov opened this issue Apr 2, 2020 · 9 comments
Assignees
@kkartunov
Labels
Prod Env Environment QA Pass
Milestone
v0.30.3

Comments

@kkartunov
Copy link
Collaborator

TC Footer should be updated to meet new design https://marvelapp.com/535c9ga/screen/66441662/handoff
@kkartunov kkartunov self-assigned this Apr 2, 2020
kkartunov added a commit that referenced this issue Apr 13, 2020
@kkartunov
TC Footer #4158
e67f2e2
@kkartunov kkartunov mentioned this issue Apr 13, 2020
Merged
@sandhiyakavi
Copy link
Collaborator

Overlapping occurs with footer in My profile page.

image

@kkartunov while clicking on the links in Footer, it is directing to Dev environment pages,is it the expected behaviour? Please clarify my doubt

11

@sandhiyakavi sandhiyakavi added QA Fail QA verification on Dev has failed. Assignee to redo the fix. Test Env Environment labels Apr 14, 2020
@sandhiyakavi
Copy link
Collaborator

cc: @SathyaJayabal

@kkartunov
Copy link
Collaborator Author

@sandhiyakavi yes it is expected links to direct to dev. They are env based and will direct to prod on prod.

I pushed a fix for the overlap issue. Please, re-test when deployment ready.

@sandhiyakavi
Copy link
Collaborator

Restested the issue. Working as expected

image

@sandhiyakavi sandhiyakavi added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Apr 14, 2020
@sushilshinde sushilshinde mentioned this issue Apr 14, 2020
Merged
@hokienick
Copy link

The youtube link should be: https://www.youtube.com/c/TopcoderOfficial

Also can we remove the tooltip over the social icons?
Screen Shot 2020-04-14 at 9 51 09 AM

@Oanh-and-only-Oanh Oanh-and-only-Oanh added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed QA Pass labels Apr 14, 2020
kkartunov added a commit that referenced this issue Apr 15, 2020
@kkartunov
#4158 social links fixes
aabd83a
@kkartunov kkartunov added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Apr 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on test env

@SathyaJayabal
Copy link
Collaborator

footer.mov.zip

@SathyaJayabal SathyaJayabal added this to the v0.30.3 milestone Apr 16, 2020
@sandhiyakavi
Copy link
Collaborator

Verified on beta Env. working as expected.

#4158.zip

@sandhiyakavi sandhiyakavi added Beta Env Environment and removed Test Env Environment labels Apr 16, 2020
@sushilshinde sushilshinde mentioned this issue Apr 16, 2020
Merged
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Apr 16, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-04-16 at 7 48 57 PM

@kkartunov kkartunov mentioned this issue Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.30.3
Development

No branches or pull requests
5 participants
@hokienick @kkartunov @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal