Skip to content

Statistic tables (looker tag) refresh #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Feb 10, 2020 · 5 comments
Closed

Statistic tables (looker tag) refresh #3976

kkartunov opened this issue Feb 10, 2020 · 5 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Milestone
v0.20.02

Comments

@kkartunov
Copy link
Collaborator

Update Looker components to match new look and feel as per https://marvelapp.com/535c9ga/screen/66047176/handoff

Test: https://www.topcoder.com/community/statistics

Note: statistics are available only on prod env not on dev.
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Feb 10, 2020
@kkartunov kkartunov self-assigned this Feb 10, 2020
kkartunov added a commit that referenced this issue Feb 10, 2020
@kkartunov
Implements #3976
3276225
@kkartunov kkartunov mentioned this issue Feb 10, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

@kkartunov , this cannot be tested on test env ?

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Feb 11, 2020 •
edited
Loading

@kkartunov , verified on beta env (feature branch)
Table header and sorting is missing
Handles need to be a link
Screenshot 2020-02-11 at 3 27 26 PM

Screenshot 2020-02-11 at 3 27 12 PM

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 11, 2020
@SathyaJayabal
Copy link
Collaborator

As per @kkartunov's comments, verified one sample table where headers and handle links are implemented.

Screenshot 2020-02-11 at 3 51 38 PM

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 11, 2020
@SathyaJayabal
Copy link
Collaborator

Verified on Beta (Develop branch)
Screenshot 2020-02-12 at 1 30 01 PM

@SathyaJayabal SathyaJayabal added this to the 0.20.02 milestone Feb 12, 2020
@kkartunov kkartunov mentioned this issue Feb 12, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified for sample table in production.

@kkartunov , please apply the styles for the rest of the tables and verify.
Screenshot 2020-02-12 at 6 20 12 PM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.20.02
Development

No branches or pull requests
2 participants
@kkartunov @SathyaJayabal