Skip to content

[$10] - Number of filters applied count is not displayed in the filter area #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Aug 28, 2017 · 6 comments
Closed
Assignees

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 28, 2017

Steps to Reproduce

Actual Result(s)

  • Number of filters applied count must displayed in the blue circle in the filter area when user click on a technology tag

Expected Result(s)

  • Number of filters applied count is not displayed in the filter area when user click on a technology tag

Environment

  • Device(s): Samsung Galaxy S5
  • Operating System: Android 6.0.1
  • Browser(s): Chrome

Image/Video/JS Log/Console Log (If not attached here, Please check the comments section)

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 28, 2017

4 1
4 2

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 28, 2017

@birdofpreyru
Copy link
Collaborator

@sdgun I believe, it is intentional to save space in the mobile layout. @vic-topcoder ?

@vic-tian
Copy link

I accept it as a bug - the consistency of the design is broken in this case. It should be showing the number of filters applied on the list the same way as on desktop - mechanics is the same. For mobile design we should remove the label of the menu and keep the icon with the badge (when there are modifiers). The design was not correct. Good catch!

Please update to the following:
screen shot 4

@birdofpreyru birdofpreyru changed the title Number of filters applied count is not displayed in the filter area [$10] - Number of filters applied count is not displayed in the filter area Aug 28, 2017
@birdofpreyru
Copy link
Collaborator

Accepted, 3 points.

@twicoder twicoder self-assigned this Aug 29, 2017
twicoder pushed a commit that referenced this issue Aug 29, 2017
@twicoder
Copy link

PR #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants