Skip to content

Remove Subscribe for Newsletter option in Settings page #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Feb 4, 2020 · 5 comments
Closed

Remove Subscribe for Newsletter option in Settings page #3641

Oanh-and-only-Oanh opened this issue Feb 4, 2020 · 5 comments
Assignees
@kkartunov
Labels
Beta Env Environment P4 Low (resolve within 2 weeks) Prod Env Environment QA Pass
Milestone
v0.28.1

Comments

@Oanh-and-only-Oanh
Copy link

Remove the newsletter subscribe switch in the settings for members since we are not doing the Weekly Newsletters anymore.
@Oanh-and-only-Oanh Oanh-and-only-Oanh added the P4 Low (resolve within 2 weeks) label Feb 4, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Remove Scribe for Newsletter option in Settings page Remove Subscribe for Newsletter option in Settings page Feb 5, 2020
@kkartunov kkartunov mentioned this issue Mar 30, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

@kkartunov @Oanh-and-only-Oanh , since newsletter preferences were the only section present under email preferences, now the email tab is empty. We should remove the email tab too as it is not a good UX to have an empty tab.

Screenshot 2020-03-31 at 9 01 12 AM

@SathyaJayabal SathyaJayabal added the Need clarification Need clarification to proceed fixing the issue further label Mar 31, 2020
@kkartunov
Copy link
Collaborator

@SathyaJayabal we need to keep it because of:

  1. All other tabs are external and load in new page thus can't begin with new one which breaks tabs.
  2. We could add email preferences for general newsletter latter in this section.

Please, feel free to proceed with this one.

@SathyaJayabal
Copy link
Collaborator

@kkartunov , marking this as pass as per comment above.

@SathyaJayabal SathyaJayabal added QA Pass and removed Need clarification Need clarification to proceed fixing the issue further labels Mar 31, 2020
@SathyaJayabal SathyaJayabal reopened this Apr 2, 2020
@Jobee1
Copy link
Collaborator

Jobee1 commented Apr 2, 2020 •
edited
Loading

Tested in Beta environment: Only E-mail Preferences is displayed.

3641

@SathyaJayabal SathyaJayabal added this to the v0.28.1 milestone Apr 2, 2020
@SathyaJayabal SathyaJayabal added the Beta Env Environment label Apr 2, 2020
@kkartunov kkartunov mentioned this issue Apr 2, 2020
Merged
@SathyaJayabal SathyaJayabal added the Prod Env Environment label Apr 2, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-04-02 at 5 13 33 PM

@LieutenantRoger LieutenantRoger mentioned this issue Apr 4, 2020
Closed
@SathyaJayabal SathyaJayabal mentioned this issue Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Beta Env Environment P4 Low (resolve within 2 weeks) Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.28.1
Development

No branches or pull requests
4 participants
@kkartunov @Oanh-and-only-Oanh @Jobee1 @SathyaJayabal