Skip to content

[$50] Fix the review issues on challenge 30113877 #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
veshu opened this issue Feb 2, 2020 · 3 comments
Open

[$50] Fix the review issues on challenge 30113877 #3631

veshu opened this issue Feb 2, 2020 · 3 comments
Labels
tcx_OpenForPickup

Comments

@veshu
Copy link
Contributor

veshu commented Feb 2, 2020

Branch to work: https://github.com/topcoder-platform/community-app/tree/feature-details-page-suggestion-cards

  1. Fix issues with npm run test
  2. Add tests
  3. Fix issues from https://software.topcoder.com/review/actions/ViewReview?rid=490180
@veshu
Copy link
Contributor Author

veshu commented Feb 2, 2020

@yoution please assign this yourself.

@yoution
Copy link
Contributor

yoution commented Feb 2, 2020

please assign to me

yoution added a commit to yoution/community-app that referenced this issue Feb 2, 2020
@yoution
topcoder-platform#3631 fix review issues on challenge 30113877
530fb6a
@yoution
Copy link
Contributor

yoution commented Feb 2, 2020

@veshu please reivew #3633

veshu added a commit that referenced this issue Feb 2, 2020
@veshu
Merge pull request #3633 from yoution/feature-details-page-suggestion…
b30748a 
…-cards

#3631 fix review issues on challenge 30113877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tcx_OpenForPickup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veshu @yoution