Skip to content

[$50] UX change to keyword search on Challenge Listings #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Jan 20, 2020 · 46 comments
Closed

[$50] UX change to keyword search on Challenge Listings #3582

Oanh-and-only-Oanh opened this issue Jan 20, 2020 · 46 comments

Comments

@Oanh-and-only-Oanh
Copy link

Please display message below if user searches a tech stack that has no LIVE challenges.

"No Live Challenges found"

@Oanh-and-only-Oanh Oanh-and-only-Oanh added Challenge Listing P4 Low (resolve within 2 weeks) labels Jan 20, 2020
@LieutenantRoger LieutenantRoger changed the title UX change to keyword search on Challenge Listings [$30] UX change to keyword search on Challenge Listings Jan 20, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113143 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113143 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger @veshu PR done in #3584

hope the perfect branch is used to raise PR. kindly confirm

@LieutenantRoger
Copy link
Collaborator

Hello @PrakashDurlabhji

  1. Could you please raise PR against this branch hot-fix-no-result, apologize that I didn't provide this info in advance.

  2. Regarding the PR, the CI tests need to be fixed/passed as well. issue 3582 fix #3584

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger yes doing the same

@LieutenantRoger
Copy link
Collaborator

@PrakashDurlabhji could you please tell what do you mean yes doing the same ?

Your PR has two issues above which need to be resolved. Please let me know if you able to work on it or we can open it for others.

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger just 10 mins

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger new PR #3588

@LieutenantRoger
Copy link
Collaborator

Hi @PrakashDurlabhji

We should only show the text for once: https://take.ms/bsrGX

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger can you please check now? Ideally h3 should show dark font and not 3 times.

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Jan 27, 2020

@PrakashDurlabhji The text is fine now, but I found another issue:

1)When I visit the challenge page for the first time after launching the community app, I see this.
After I refresh the browser, the app became normal. So this should be another bug.
image

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger actually this bug is not due to my PR , because it even happens with me before,
I feel it is an issue with topcoder site itself, u would have observed too that:

  1. Sometimes when we logout from topcoder site and close the current tab.
  2. then in different tab open, topcoder.com/challenges.
  3. you willl see that on top right corner your topcoder handle would appear for 1 sec and then it will disappear and login button wud appear.

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger

1.hence while above happens, auth.user was true for 1 sec and "No live challenges found in My challenges" appear

2.after 1 sec though auth.user is false but same is not reflected unless we refresh the app.

@LieutenantRoger
Copy link
Collaborator

Hmm, I can't agree with you on this, this seems an obvious issue with the challenge listing area.
please fix the error scenario showed up in the snapshot, thanks.

#3582 (comment)

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger solving it

@PrakashDurlabhji
Copy link
Contributor

@LieutenantRoger update done , can you please check now and provide feedback if any, waiting

@LieutenantRoger
Copy link
Collaborator

Sure @PrakashDurlabhji
I'm reviewing now, sorry for the late due to I'm traveling today.

@LieutenantRoger
Copy link
Collaborator

looks fine now. Thanks.

@SathyaJayabal
Copy link
Collaborator

Verified in dev
Screenshot 2020-01-29 at 10 18 24 AM
Screenshot 2020-01-29 at 10 18 40 AM
Screenshot 2020-01-29 at 10 18 59 AM
Screenshot 2020-01-29 at 10 19 13 AM

@lakshmiathreya
Copy link

@SathyaJayabal pls verify on Beta prior to Release...

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env labels Jan 29, 2020
@SathyaJayabal
Copy link
Collaborator

Verified in beta
Screenshot 2020-01-29 at 12 35 03 PM
Screenshot 2020-01-29 at 12 35 14 PM
Screenshot 2020-01-29 at 12 35 23 PM
Screenshot 2020-01-29 at 12 35 34 PM

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 29, 2020

Verified in prod
Screenshot 2020-01-29 at 5 21 44 PM
Screenshot 2020-01-29 at 5 21 52 PM
Screenshot 2020-01-29 at 5 21 59 PM
Screenshot 2020-01-29 at 5 22 07 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30113143

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants