Skip to content

[$80] Stats for CODE track not getting computed/displayed #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oanh-and-only-Oanh opened this issue Jan 15, 2020 · 17 comments
Open

[$80] Stats for CODE track not getting computed/displayed #3571

Oanh-and-only-Oanh opened this issue Jan 15, 2020 · 17 comments
Assignees
Labels
On hold P1 Urgent (resolve within 24 hours) Rating tcx_Assigned

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Jan 15, 2020

Describe the bug
We have CODE ratings, but the other 3 stats aren’t getting computed/displayed

To Reproduce
Steps to reproduce the behavior:

  1. go to https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE
  2. See that Stats for RANK, PERCENTILE, are all zero.

Screenshots
image

@Oanh-and-only-Oanh
Copy link
Author

According to Tony, "it probably just needs to update the data loader that computes those stats.
it’s already doing it for other challenge types, but i think CODE challenges are currently ignored by the calc"

@kkartunov kkartunov changed the title Stats for CODE track not getting computed/displayed [$80] Stats for CODE track not getting computed/displayed Jan 15, 2020
@kkartunov kkartunov assigned kkartunov and unassigned kkartunov Jan 15, 2020
@kkartunov kkartunov added P1 Urgent (resolve within 24 hours) tcx_OpenForPickup labels Jan 15, 2020
@kkartunov
Copy link
Collaborator

@topcoder-platform/topcodercompetitors this is now open for pickup.

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112839 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@LieutenantRoger LieutenantRoger self-assigned this Jan 16, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112839 has been updated - it has been assigned to lieutenantroger.

This is an automated message for crazyk via Topcoder X

@LieutenantRoger
Copy link
Collaborator

Hi @kkartunov

I can get the RELIABILITY data based on received data. Could you tell how the RANK and PERCENTILE is calculated ?

@kkartunov
Copy link
Collaborator

@LieutenantRoger thanks for pickup. Please, PR to https://github.com/topcoder-platform/community-app/tree/feature-member-profiles branch. Thanks

check this comment #3571 (comment). I think you should inspect the action/reducer payload and see why code is ignored. Makes sense?

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Jan 16, 2020

Hi @kkartunov & @Oanh-and-only-Oanh

The frontend code didn't missing the calc, for CODE track, there is no RANK, PERCENTILE, RELIABILITY data returned from the service call. For the old ASSEMBLY track, these values are returned from the service call directly.

Right now, RELIBILITY can be calculated based on the returned data by frontend, but I don't know how the RANK and PERCENTILE is calculated.

@kkartunov
Copy link
Collaborator

@LieutenantRoger can you see how it is done for other types of track challenges? Actually they same for all types of challenges I assume.

We have here an article about ratings here https://www.topcoder.com/thrive/articles/Ratings check it out.

@kkartunov
Copy link
Collaborator

@LieutenantRoger
Copy link
Collaborator

Hmm, I can't find relevant calculation method for this in frontend codebase. I use a POSTMAN request to get the statistics data from the API directly , the ASSEMBLY is returning all the necessary data from the service call, but the CODE part is not having the relevant data.

Same for other type challenges: some have the relevant data, some not.

So the question is , is this the correct way we calculate this info at frontend ? Per the investation so far, it should be calculated in the backend codebase.

BTW, the current codebase is calling V3 API.

@kkartunov
Copy link
Collaborator

@LieutenantRoger can you give example what you mean by: "Same for other type challenges: some have the relevant data, some not."?

Also, use one that works/has the data and apply for CODE similarly as well. I think this is what needs to be accomplished here so let's do it.

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Jan 17, 2020

I actually meant there is no front end calculation for the related values. They are retrieved from backend service call directly

For Assembly, UI_PROTOTYPE track, there is related data returned from the service call

FOR CODE, FIRST2FINISH , there are not.

The comment above(https://github.com/topcoder-platform/community-app/issues/3571#issuecomment-574753336) is wrong because I didn’t see there are places that front end codebase will do the calculation

So we can’t perform the ones having the data on Code track as the data should be retrieved from service respond directly. And for the code track data, backend api didn’t respond us with related data. We then not able to show them on the UI

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Jan 17, 2020

For more info: visit this link in browser: https://api.topcoder-dev.com/v3/members/{{handle}}/stats

We can use this API to get the data directly. Please try your own handle in the url, to get the full data.
This way can't get other member's full data. But it's enough to demonstrate the issue here

BTW, I think you can visit this link: https://api.topcoder.com/v3/members/{{handle}}/stats to get any member's statistics data, replacing {{handle}} with member's real handle:

e.g: https://api.topcoder.com/v3/members/birdofpreyru/stats

@LieutenantRoger
Copy link
Collaborator

Hi @kkartunov please let me know if you still not able verify this. Maybe backend API update is required

@LieutenantRoger
Copy link
Collaborator

Up

@kkartunov
Copy link
Collaborator

Putting here Tony's info for reference:
"those calcs are part of the data loader. I think it actually roots back to the loader that transforms data from the informix oltp to the DW. There is an array of challenge types that it uses to do things like calculate ratings, reliability, etc. I’m pretty sure the appropriate missing challenge types will need to be added and then the loaders will calculate."

I think it’s related to this code: https://github.com/topcoder-platform/tc-website/blob/dev/src/main/com/topcoder/utilities/dwload/TCLoadTCS.java#L753

@kkartunov
Copy link
Collaborator

@LieutenantRoger we have confirmation that API updates needed for this one here. Therefore I am putting it On hold label. Thanks for your cooperation so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold P1 Urgent (resolve within 24 hours) Rating tcx_Assigned
Projects
None yet
Development

No branches or pull requests

4 participants