Skip to content

Contentful leaderboards fixes #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Jan 9, 2020 · 16 comments
Closed

Contentful leaderboards fixes #3552

kkartunov opened this issue Jan 9, 2020 · 16 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Milestone
v0.19.05

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Jan 9, 2020 •
edited
Loading

Design to follow is here: https://marvelapp.com/5554efd/screen/65173645

Entry component: https://github.com/topcoder-platform/community-app/tree/develop/src/shared/containers/tco/Leaderboard
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Jan 9, 2020
@kkartunov kkartunov self-assigned this Jan 9, 2020
@manoj389852
Copy link

Kindly give permission to work on this issue

@kkartunov kkartunov changed the title Contentful components CSS fixes Contentful components fixes Jan 16, 2020
@kkartunov kkartunov changed the title Contentful components fixes Contentful leaderboards fixes Jan 16, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added the P2 Important (resolve within 3 days) label Jan 16, 2020
kkartunov added a commit that referenced this issue Jan 17, 2020
@kkartunov
Implements #3552
fbf464d
@kkartunov kkartunov mentioned this issue Jan 17, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 20, 2020 •
edited
Loading

@kkartunov @sushilshinde , Can you please give us the URL to test this ? Where is the fix deployed ?
cc @Oanh-and-only-Oanh

sushilshinde added a commit that referenced this issue Jan 20, 2020
@sushilshinde
Merge pull request #3579 from topcoder-platform/feature-contentful
d4133a8 
Implements #3552
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal test URLs are here:

I think it works but please do QA.
Thanks

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 20, 2020 •
edited
Loading

  • Leaderboard podium cards - "fulfillment" text color should be #2A2A2A. Demo (Fixed)

Screenshot 2020-01-20 at 5 29 33 PM

  • Leaderboard podium - move the 1st,2nd and 3rd card upper to be closer to that tabs. In case of title is empty do not render H2 tag that makes layout expand. (Not Fixed)
    The cards have not been moved up.

Screenshot 2020-01-20 at 5 34 05 PM

Screenshot 2020-01-20 at 5 34 25 PM

  • Add 4th place podium card to leaderboards and required support for it. (Not Fixed)

Some of the track leaderboards have only three cards, even though the rules say four finalists per stage
Screenshot 2020-01-20 at 5 44 32 PM
Tracks :
Algorithm - shows three cards (top 1 gets a berth to onsite round and next 11 advance from this stage to online round 4, so I am not sure if 3 or 4 cards is correct for this track, maybe just one card )
Development - shows three cards, but four finalists are selected from each stage
F2F - shows three cards, but four finalists are selected from each stage
QA - shows three cards, but four finalists are selected from each stage
UI Design - shows three cards, but four finalists are selected from each stage

  • Alignment issue : The stage headers, the leaderboard title and the leaderboard table is not aligned like in the design.

Screenshot 2020-01-20 at 5 54 54 PM

Screenshot 2020-01-20 at 5 56 37 PM

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 20, 2020
@SathyaJayabal
Copy link
Collaborator

cc @kkartunov

@kkartunov
Copy link
Collaborator Author

@SathyaJayabal thank you for your testing.

Please note that Contentful is a little different than the other parts of the app. We will need to sync together to complete tasks.

For this one:

  • Podium cards are moved upper as per spec. You can compare it to the current prod http://tco20.topcoder.com/competition-overview/marathon/leaderboard see Stage 1.

  • You see the demo is switched to 4. Rest needs to be switched from Contentful which we will do when we have this one in production.

  • Alignment issues are known. This can't be other as because of the leaderbord table width differences between design and real prod. In prod we do have 1024px width but in design is 1035px.

I think we should accept this one.

@Oanh-and-only-Oanh Oanh-and-only-Oanh added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 20, 2020
@Oanh-and-only-Oanh
Copy link

@SathyaJayabal , thanks for testing. @kkartunov, thanks for the follow up explanation. I'm marking this as QA Pass per the comments.

@kkartunov kkartunov mentioned this issue Jan 21, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh @kkartunov , Is this bug only for the demo track. Can we verify this issue for the one track and close this bug?

@SathyaJayabal
Copy link
Collaborator

Verified in production.
Screenshot 2020-01-21 at 3 13 27 PM
Screenshot 2020-01-21 at 3 14 12 PM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Jan 21, 2020
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed Ready for Prod QA labels Jan 22, 2020
@Oanh-and-only-Oanh
Copy link

@SathyaJayabal, please close out the tickets that pass QA in PROD. Thank you.

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh , the changes have been made to just one track(for demo). Waiting for the changes to be applied to the other tracks before closing this ticket.

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh , I am closing this out. We can create a new issue for the rest of the tracks.

@SathyaJayabal SathyaJayabal added this to the Community App 0.19.05 milestone Jan 22, 2020
@kkartunov kkartunov reopened this Jan 23, 2020
@kkartunov
Copy link
Collaborator Author

Not in prod

@kkartunov kkartunov removed the Prod Env Environment label Jan 23, 2020
@SathyaJayabal SathyaJayabal added Prod Env Environment QA Pass and removed QA Pass in PROD Passed verification on Production labels Jan 23, 2020
@SathyaJayabal
Copy link
Collaborator

Verified.
Screenshot 2020-01-23 at 2 10 56 PM

@SathyaJayabal
Copy link
Collaborator

@bug-hunt-helper help

@bug-bash-helper
Copy link

Hi @SathyaJayabal.

add label

To add label to the issue, add comment like below with comma-separated list of labels:

@bug-hunt-helper add label: Label Name 1, Label Name 2, Label Name 3

remove label

To remove label from the issue, add comment like below with comma-separated list of labels:

@bug-hunt-helper remove label: Label Name 1, Label Name 2, Label Name 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.19.05
Development

No branches or pull requests
4 participants
@kkartunov @Oanh-and-only-Oanh @SathyaJayabal @manoj389852