Skip to content

[$80] Performance issue while pulling up challenges from listing page #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-yadav opened this issue Jan 8, 2020 · 21 comments
Closed

[$80] Performance issue while pulling up challenges from listing page #3548

m-yadav opened this issue Jan 8, 2020 · 21 comments
Assignees
@gets0ul
Labels
Challenge Listing P3 Normal (resolved within 7 days) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v0.19.07

Comments

@m-yadav
Copy link

m-yadav commented Jan 8, 2020 •
edited by Oanh-and-only-Oanh
Loading

Describe the bug

  1. The user tried to access the below URL to search for salesforce challenges ran but nothing loaded on the screen for around 30 seconds.

https://www.topcoder.com/challenges/?bucket=past&tab=details&filter[text]=salesforce

Please improve performance to reduce loading time.
@m-yadav
Copy link
Author

m-yadav commented Jan 8, 2020

cc @Oanh-and-only-Oanh

@kkartunov kkartunov changed the title Performance issue while pulling up challenges from listing page [$60] Performance issue while pulling up challenges from listing page Jan 16, 2020
@kkartunov kkartunov added tcx_OpenForPickup P3 Normal (resolved within 7 days) labels Jan 16, 2020
@kkartunov
Copy link
Collaborator

@topcoder-platform/topcodercompetitors this one is now open for pickup. Please PR against the branch https://github.com/topcoder-platform/community-app/tree/feature-member-profiles

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112906 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@gets0ul
Copy link
Collaborator

gets0ul commented Jan 20, 2020

@kkartunov is this still open? do you have the screen recording for this issue? Thanks

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$60] Performance issue while pulling up challenges from listing page Performance issue while pulling up challenges from listing page Jan 20, 2020
@LieutenantRoger LieutenantRoger changed the title Performance issue while pulling up challenges from listing page [$80] Performance issue while pulling up challenges from listing page Jan 20, 2020
@LieutenantRoger
Copy link
Collaborator

Hi @topcoder-platform/topcodercompetitors

This ticket is open for pick up.

Try to reproduce it on current production page: www.topcoder.com/challenges, you could easily spot the issues will show up.

Please let me know if you can't reproduce this or have some questions about this.

@LieutenantRoger
Copy link
Collaborator

The fix should be based on branch hot-fix-performance

@gets0ul
Copy link
Collaborator

gets0ul commented Jan 20, 2020

@LieutenantRoger the issue is with pulling up Past challenges with search keyword, right?

@LieutenantRoger
Copy link
Collaborator

Hi @gets0ul

Yes , it is.

@gets0ul gets0ul self-assigned this Jan 21, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112906 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

@gets0ul gets0ul mentioned this issue Jan 21, 2020
Merged
@LieutenantRoger
Copy link
Collaborator

Per my testing: with the fix, it will show the result in 17s for now.

We will accept this for now.

@Oanh-and-only-Oanh
Copy link

QA note: This ticket should pass QA if performance is under 18 secs. Thank you.

LieutenantRoger added a commit that referenced this issue Jan 22, 2020
@LieutenantRoger
Merge pull request #3587 from gets0ul/issue_3548
20232b0 
Fix for Issue #3548 Pulling up Past Challenges
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 22, 2020 •
edited
Loading

The time to show the results is based on the keyword that is being searched. For example if you have some recently completed challenges with the searched keyword, the results show up faster. If you do not have any recently completed challenges with the searched keyword, then the search takes longer.

Also the page becomes more and more unresponsive as we keep searching
https://vimeo.com/user54657926/review/386431124/b39c366ded

@SathyaJayabal SathyaJayabal added Dev Env QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 22, 2020
@SathyaJayabal
Copy link
Collaborator

please check the video here
https://drive.google.com/open?id=1btecsA2_FqXDooMWLcDUPw345Q4C0ZAe

@SathyaJayabal
Copy link
Collaborator

comment from dev: Hey @picachui thanks for testing, but it seems you are testing not the correct area. It looks if we use Keyword in the filter panel, it will be searched as a 'tag', but the ticket is trying to fix the 'Search challenges' box when we open up the www.topcoder.com/challenges page.

After retesting as per above comment, search is displaying results below 18 secs . Verified in dev.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 22, 2020
@LieutenantRoger LieutenantRoger mentioned this issue Jan 22, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 23, 2020 •
edited
Loading

@LieutenantRoger , when the user searches for a keyword that is not present in the past challenges, the search results (Message "No Past Challenges found") must be displayed at a reasonable amount of time. At present the search keeps going on for more than a few minutes.

Please see video
https://drive.google.com/open?id=1jwq43QZpOgPzeR1lv-1b0oi_ErqeBOax
For other examples, the results is displayed within 18 seconds
Please see video
https://drive.google.com/open?id=1rtWNdpDim5mStAYvUVEaBlV7_Ib-qTBu

cc @Oanh-and-only-Oanh

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Dev Env QA Pass labels Jan 23, 2020
@LieutenantRoger
Copy link
Collaborator

Hi, @Oanh-and-only-Oanh

Please take a look above raised issue

@Oanh-and-only-Oanh
Copy link

@LieutenantRoger, what @SathyaJayabal noticed can be logged as a separate issue. Let's accept this fix and close out this ticket. Please open another separate ticket for:

"when the user searches for a keyword that is not present in the past challenges, the search results (Message "No Past Challenges found") must be displayed at a reasonable amount of time. At present the search keeps going on for more than a few minutes.

Please see video
https://drive.google.com/open?id=1jwq43QZpOgPzeR1lv-1b0oi_ErqeBOax

@LieutenantRoger
Copy link
Collaborator

Sure.

Hi @SathyaJayabal please accept this fix and mark it pass.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 24, 2020
@LieutenantRoger LieutenantRoger mentioned this issue Jan 24, 2020
Merged
@lakshmiathreya lakshmiathreya added this to the 0.19.07 milestone Jan 29, 2020
@SathyaJayabal
Copy link
Collaborator

Verified in beta
past search.mov.zip

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Jan 29, 2020
@SathyaJayabal
Copy link
Collaborator

Verified in prod
past serach prod.mov.zip

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30112906

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
Challenge Listing P3 Normal (resolved within 7 days) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v0.19.07
Development

No branches or pull requests
8 participants
@LieutenantRoger @gets0ul @kkartunov @crazyk07 @m-yadav @Oanh-and-only-Oanh @lakshmiathreya @SathyaJayabal