Devices - add lookup data

[ajefts]

When users are adding devices to their profiles, allow them to select from structured data values instead of free form text entry. For example, right now someone needs to type in "iPhone 6". So, we have that data entered in different ways: "iphone 6", "IPHONE 6", "iphone6", etc.

The value add here is that this data helps us understand the capacity in the community to do work that requires specific devices, such as testing mobile apps.

[ajefts]

Link to feature: https://tcprod.productboard.com/feature-board/planning/features/1763052

[SathyaJayabal]

@drasticdpk, I cant find the feature on the product board. Can you add the link to the feature description or challenge spec ?

[drasticdpk]

@SathyaJayabal here the requested details :
https://www.topcoder.com/challenges/30113988?tab=details

[SathyaJayabal]

1. Contact support should be a link to email support

@drasticdpk , Clarifications needed for the below

1. Can you share the rules on the order in which the device data is displayed once it is added. There seems to be some discrepancies from production.
   Example:
   When Only Type and Manufacturer is added, Production displays Manufacturer first and dev displays Type first. There are similar differences as to what is displayed on the first line and what is displayed below.

2. Can you data where you have more than one model for a manufacturer and more than one OS for a model ? Can you also add data where you have more than 100 records in a drop down?

[SathyaJayabal]

@drasticdpk
Unable to add user trait error.
Steps to reproduce:

1. Add only one device
2. click on edit the device
3. Delete the device
4. Now edit the device in the still open edit window (make sure to change the type)
5. click on "Edit Device to your list"

See video
edit device.mov.zip

Another similar issue is (this issue also happens in production):

1. add two devices ( A and B)
2. click edit for on device A
3. now delete the device A
4. edit device A using the still open edit window and save the edit
5. Device B will be updated with the new changes.

See video
edit delete device.mov.zip

[Oanh-and-only-Oanh]

@drasticdpk and @SathyaJayabal, regarding 1. "Contact support should be a link to email support", this doesn't need to be a link.

[drasticdpk]

@SathyaJayabal , I have requested API team to update data accordingly to meet the test scenario.
FYI Meantime you can test that scenario from postman too.
https://github.com/topcoder-platform/lookups-api/tree/develop/docs

[drasticdpk]

@SathyaJayabal

Can you share the rules on the order in which the device data is displayed once it is added. There seems to be some discrepancies from production.

Updated as production.

Can you data where you have more than one model for a manufacturer and more than one OS for a model ? Can you also add data where you have more than 100 records in a drop down?

To meet this scenario, please use Device Type: "Smartphone", Manufacturer : "Samsung"

Other issue has been fixed please test.
Note : Please don't select device type as "Mobile" it is no longer going to be in the dropdown. (already informed API team to remove it.

[SathyaJayabal]

@drasticdpk , everything looks good except for this one issue.
From spec
"API can return max 100 rows at time. User should get that next data by scrolling it on UI Section. Mainly for Model Dropdown"

For the example (Device Type: "Smartphone", Manufacturer : "Samsung"), the first 100 records are loaded, but on scrolling further records are not loading.
devices.mov.zip

[SathyaJayabal]

@drasticdpk , verified on test

[sushilshinde]

Production deployment on hold as production v5/lookups API isn't ready yet.

@Oanh-and-only-Oanh @drasticdpk

[LieutenantRoger]

1. When you edit the device and click on save without updating any field, you get the "Looks lie you have already entered this device" error. The error must not be displayed in keeping with the existing behaviour.
2. A device is checked for uniqueness only when all the four DDs are filled. For example I am able to add the. below device twice because I have not filled in the OS value. Is this the expected behaviour?

1. The error message is removed under this sceario

2. Hmmm, in my opinion this should be expected, so I didn't change anything for this point.

3. Success message popup is displayed when we add a device successfully, so the error popup message is following the same style, (success is using green color, error is using red color).

[sandhiyakavi]

working as expected

[SathyaJayabal]

@LieutenantRoger , I am not sure of the red colour used in the error message. I am marking this as QA pass as its a minor issue. @Oanh-and-only-Oanh Do we have a style guide for it? I could not find it in this guide
https://zeroheight.com/1g0pfacwv/p/4098cf-buttons--links/b/62b18f

[SathyaJayabal]

verified delete conf message is centered

[Oanh-and-only-Oanh]

@Dara-K, can you provide GUI KIT for this message?

[Dara-K]

This is how a modal with buttons and title should look: https://marvelapp.com/5554efd/screen/66554187
If you need the exact design, I can do that. In this case the delete button should be the pink one from our GUI KIT and be on the right side, and the cancel should be on left side outlined.

GUI KIT: https://marvelapp.com/4f8i35i/screen/61272619

[SathyaJayabal]

@Dara-K , sorry for the misunderstanding, we wanted the kit for this error message.
#3547 (comment)

[Dara-K]

Yes, I was saying we don't have that component in the GUI KIT now. We keep updating it as we go on and we need things.

I designed it now here: https://marvelapp.com/5ij7312/screen/67963488

[LieutenantRoger]

Hi @Dara-K
I think we are discussing the tostar message in this snapshot.

But I can see you have re-designed the popup https://marvelapp.com/5ij7312/screen/67963488

By the way, we have merged the functionality code into develop branch for this ticket.

@Oanh-and-only-Oanh do we need to integrate the new style that @Dara-K has designed here: https://marvelapp.com/5ij7312/screen/67963488 ?

[SathyaJayabal]

@LieutenantRoger @Dara-K @Oanh-and-only-Oanh If we are updating the style, we need to do so for all the pages on the profile settings. So, creating new issue to track the design update to the pop-ups.

#4194

[Dara-K]

Oh okay - I thought you're referring to the modal. Thanks for the clarification.

We don't have a style defined for the tostar message neither, but the modal window is also following the old style as well. I will re-design these 2 to follow the existing style on the site and send you later today. And we shouldn't mix the new style with current style, until a full redesign.

[Dara-K]

Here are the notification states: https://marvelapp.com/11607af4/screen/67982872

The one to use in the above case is the Warning one.

The modal window should be designed like this: https://marvelapp.com/11607af4/screen/67982871 (the above example with blue buttons is from the old Topcoder style 2013).

The guidelines for this GUI KIT are these ones: https://marvelapp.com/c7h2a6h/screen/59648056

Let me know if you need other elements.

[SathyaJayabal]

@Dara-K , thank you.
We will track these updates in #4194

[Oanh-and-only-Oanh]

@SathyaJayabal and @LieutenantRoger, let's update the popup message to the GUI KIT guidelines. Is this the last remaining issue for devices?

[SathyaJayabal]

@Oanh-and-only-Oanh , wont it be better to update the popup messages for all the settings pages (education, work etc) together as a separate activity as all these pages use the same older style ?

#4194 can be used to track this.

[sandhiyakavi]

Working as expected.
#3547_test.zip

[Jobee1]

Working as expected verified on Beta Environment:
3547_beta.zip

[Jobee1]

Working on expected verified on Production environment:
3547_production.zip