Skip to content

[$30] Add Handle to member ratings page #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajefts opened this issue Nov 21, 2019 · 30 comments
Closed

[$30] Add Handle to member ratings page #3465

ajefts opened this issue Nov 21, 2019 · 30 comments

Comments

@ajefts
Copy link
Member

ajefts commented Nov 21, 2019

Let's click link of my SRM rating graph - you'll see, that the handle name "square1001" is nowhere in this page.

It's confusing whose rating graph it is, and the current only way to see is to see the link of the page. We need to add the member handle to this page.

@ajefts
Copy link
Member Author

ajefts commented Nov 21, 2019

@Oanh-and-only-Oanh Oanh-and-only-Oanh self-assigned this Nov 21, 2019
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Add Handle to member ratings page [$60] Add Handle to member ratings page Nov 27, 2019
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed their assignment Nov 27, 2019
@codeMinter
Copy link
Contributor

@ajefts @Oanh-and-only-Oanh can you share snapshot of how we want to show handle, as I don't have access to https://tcprod.productboard.com/feature-board/planning/features/3141275

@codeMinter
Copy link
Contributor

SRM

Does something like this looks good? We will have same colouring affect as rating for handle and for label "handle" like "rating" - didn't wanted to invest time into implementation first so thought to get design approval first.

@Oanh-and-only-Oanh @ajefts ☝️

@Oanh-and-only-Oanh
Copy link

@codeMinter, let's show profile picture and username and use the same coloring as their "rating". No need to have "handle" label.

@codeMinter
Copy link
Contributor

codeMinter commented Nov 30, 2019

srm_handle

@Oanh-and-only-Oanh FYI ☝️

@codeMinter
Copy link
Contributor

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Dec 2, 2019

@codeMinter, can you 1) make username name a hyperlink that directs them to the profile page 2) if no profile picture is available, make default profile picture the current default icon
image

@nithyaasworld
Copy link
Collaborator

@codeMinter @Oanh-and-only-Oanh Can we reduce the font of the handle name as it looks big if the handle name is little big?

image

image

@codeMinter
Copy link
Contributor

@nithyaasworld Sure will do so.

@codeMinter
Copy link
Contributor

codeMinter commented Dec 3, 2019

@codeMinter, can you 1) make username name a hyperlink that directs them to the profile page 2) if no profile picture is available, make default profile picture the current default icon
image

@Oanh-and-only-Oanh Since the users are landing from profile page to this screen. would adding something like < before SRM make sense here which takes them back to profile page. Thoughts ?

for 2) I checked the code, we are already using the default one if user has not profile picture. Do we have something else as default ? any pointers where I can check default pic?

@Oanh-and-only-Oanh
Copy link

@codeMinter, for 1) something like < before SRM works, 2) since we're already using the default one if user has no profile picture, no changes then.

@codeMinter
Copy link
Contributor

@Oanh-and-only-Oanh @nithyaasworld this is on test, can you help test this ?

@codeMinter
Copy link
Contributor

@Oanh-and-only-Oanh As discussed, we now show image and handle on all stats pages. It is ready on TEST server now.

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112840 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@kkartunov
Copy link
Collaborator

@rashmi73
Copy link
Contributor

@kkartunov PR #3577

@kkartunov
Copy link
Collaborator

@SathyaJayabal @nithyaasworld this is ready for testing on dev.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 22, 2020

@kkartunov

  1. Access the ratings page directly (using the url) and not from the profile page.
    https://www.topcoder.com/members/FireIce/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION
    https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE
  2. Click on < .
  3. A blank page is displayed.

< button works fine when you access the page from the profile page.

Note: I think this is the same issue as with the member handle link displaying a blank page(which is fixed now).

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Dev Env QA Pass labels Jan 22, 2020
@kkartunov
Copy link
Collaborator

@SathyaJayabal this is the same in prod. This means the ^^^ issue is not related to this one here. You should open another for this.

@SathyaJayabal
Copy link
Collaborator

@kkartunov , yes you are right. I will create a new issue.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jan 22, 2020
@SathyaJayabal
Copy link
Collaborator

@kkartunov @Oanh-and-only-Oanh , the user handle opens the profile page in a new tab. I hope this is expected behaviour.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Jan 23, 2020
@SathyaJayabal
Copy link
Collaborator

Verified in production
handle.mov.zip

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30112840

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants