-
Notifications
You must be signed in to change notification settings - Fork 212
[$30] Add Handle to member ratings page #3465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ajefts @Oanh-and-only-Oanh can you share snapshot of how we want to show handle, as I don't have access to https://tcprod.productboard.com/feature-board/planning/features/3141275 |
Does something like this looks good? We will have same colouring affect as rating for handle and for label "handle" like "rating" - didn't wanted to invest time into implementation first so thought to get design approval first. |
@codeMinter, let's show profile picture and username and use the same coloring as their "rating". No need to have "handle" label. |
@Oanh-and-only-Oanh FYI ☝️ |
@codeMinter, can you 1) make username name a hyperlink that directs them to the profile page 2) if no profile picture is available, make default profile picture the current default icon |
@codeMinter @Oanh-and-only-Oanh Can we reduce the font of the handle name as it looks big if the handle name is little big? |
@nithyaasworld Sure will do so. |
@Oanh-and-only-Oanh Since the users are landing from profile page to this screen. would adding something like for 2) I checked the code, we are already using the default one if user has not profile picture. Do we have something else as default ? any pointers where I can check default pic? |
@codeMinter, for 1) something like < before SRM works, 2) since we're already using the default one if user has no profile picture, no changes then. |
@Oanh-and-only-Oanh @nithyaasworld this is on test, can you help test this ? |
@Oanh-and-only-Oanh As discussed, we now show image and handle on all stats pages. It is ready on TEST server now. |
Contest https://www.topcoder.com/challenges/30112840 has been updated - it has been assigned to rashmi73. |
@rashmi73 thanks for pickup. Please, PR to https://github.com/topcoder-platform/community-app/tree/feature-member-profiles branch. Thanks |
@kkartunov PR #3577 |
@SathyaJayabal @nithyaasworld this is ready for testing on dev. |
< button works fine when you access the page from the profile page. Note: I think this is the same issue as with the member handle link displaying a blank page(which is fixed now). |
@SathyaJayabal this is the same in prod. This means the ^^^ issue is not related to this one here. You should open another for this. |
@kkartunov , yes you are right. I will create a new issue. |
@kkartunov @Oanh-and-only-Oanh , the user handle opens the profile page in a new tab. I hope this is expected behaviour. |
Verified in production |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30112840 |
Let's click link of my SRM rating graph - you'll see, that the handle name "square1001" is nowhere in this page.
It's confusing whose rating graph it is, and the current only way to see is to see the link of the page. We need to add the member handle to this page.
The text was updated successfully, but these errors were encountered: