Skip to content

[$60] - Can not close SubMenu of TopCoder Head[er on tablet #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elfman opened this issue Aug 26, 2017 · 1 comment
Closed

[$60] - Can not close SubMenu of TopCoder Head[er on tablet #339

elfman opened this issue Aug 26, 2017 · 1 comment
Assignees

Comments

@elfman
Copy link
Contributor

elfman commented Aug 26, 2017

Steps to Reproduce

  • iPad at landscape, Go to 'local.topcoder-dev.com:3000/challenges' (currently the Topcoder Header is not shown on public server, so I use local dev, it will be fixed in [$20] - Placeholder text of SearchBox is not in the middle #337)

  • Tap on Menu item, SubMenu appears

  • Tap on clean area of the page, the subMenu doesn't close

Actual Result(s)

  • Can not close SubMenu in landscape view on iPad

Expected Result(s)

  • When tap on empty area of page, close the submenu.

Environment

  • Device(s): iPad Air2
  • Operating System: iOS 9.3.2
  • Browser(s): Safari

Image/Video/JS Log/Console Log (If not attached here, Please check the comments section)

@elfman elfman self-assigned this Aug 26, 2017
@birdofpreyru birdofpreyru changed the title Can not close SubMenu of TopCoder Header on tablet [$60] - Can not close SubMenu of TopCoder Head[er on tablet Aug 26, 2017
@birdofpreyru
Copy link
Collaborator

Yeah, we should update header's code, to ensure that it works with clicks in addition to hovering. I.e. clicking on the main menu item's opens submenu, clicking outside of the submenu items, when the submenu is opened, closes it.

elfman added a commit to elfman/community-app that referenced this issue Aug 27, 2017
elfman added a commit to elfman/community-app that referenced this issue Aug 27, 2017
elfman added a commit to elfman/community-app that referenced this issue Aug 27, 2017
elfman added a commit to elfman/community-app that referenced this issue Aug 28, 2017
elfman added a commit to elfman/community-app that referenced this issue Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants