Skip to content

Implement all styles for buttons from Contentful #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Oct 13, 2019 · 5 comments
Closed

Implement all styles for buttons from Contentful #3387

kkartunov opened this issue Oct 13, 2019 · 5 comments
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful

Comments

@kkartunov
Copy link
Collaborator

kkartunov commented Oct 13, 2019 •
edited
Loading

Design: https://marvelapp.com/1g8j2156/screen/60434788/handoff

  • All buttons need to be available for usage from Contentful.
  • Related docs should be updated
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Oct 13, 2019
@kkartunov kkartunov self-assigned this Oct 13, 2019
@lakshmiathreya
Copy link

@kkartunov @sushilshinde pls clarify reg verification for this Issue. cc @nithyaasworld

@lakshmiathreya lakshmiathreya added the Need clarification Need clarification to proceed fixing the issue further label Oct 17, 2019
kkartunov added a commit that referenced this issue Oct 21, 2019
@kkartunov
Addon for #3387
41feb64
@kkartunov
Copy link
Collaborator Author

The demo should be here after PR is merged.

@kkartunov
Copy link
Collaborator Author

@lakshmiathreya ^^^

@kkartunov kkartunov removed the Need clarification Need clarification to proceed fixing the issue further label Oct 21, 2019
@Oanh-and-only-Oanh
Copy link

@kkartunov, it's unclear what about the buttons need to be verified or tested.

@kkartunov
Copy link
Collaborator Author

@Oanh-and-only-Oanh we want to confirm if demo https://community-app.topcoder-dev.com/examples/contentful/contentblock/3k7k1JpnSvIRrJYWs4izYi match design as per https://marvelapp.com/1g8j2156/screen/60434788/handoff

kkartunov added a commit that referenced this issue Oct 23, 2019
@kkartunov
Fix text-decoration #3387
6c106cc
kkartunov added a commit that referenced this issue Oct 24, 2019
@kkartunov
fixed padding buttons #3387
bc63ab1
sushilshinde added a commit that referenced this issue Oct 24, 2019
@sushilshinde
Merge pull request #3417 from topcoder-platform/feature-contentful
89c1bcc 
fixed padding buttons #3387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kkartunov @Oanh-and-only-Oanh @lakshmiathreya