Skip to content

Sort MM Leaderboard #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajefts opened this issue Oct 1, 2019 · 12 comments
Closed

Sort MM Leaderboard #3351

ajefts opened this issue Oct 1, 2019 · 12 comments
Assignees
Labels

Comments

@ajefts
Copy link
Member

ajefts commented Oct 1, 2019

Have sort buttons in the Registration Tab on name, ratings, registered, submitted and also add country in the leaderboard? I am personally very much used to checking how many reds are registered from how many countries on a match and if they submitted.  

@ajefts
Copy link
Member Author

ajefts commented Oct 1, 2019

@codeMinter
Copy link
Contributor

codeMinter commented Oct 16, 2019

@Oanh-and-only-Oanh FYI, we have the code ready - we are getting some backend things in place, before we make it available to QA for testing. We should be ready in 1-2 days more.

@Oanh-and-only-Oanh
Copy link

@codeMinter, the sorting for username isn't alphabetical.
image

@codeMinter
Copy link
Contributor

codeMinter commented Oct 16, 2019

@Oanh-and-only-Oanh We used lex order. As discussed, will push the change to make it alpha sort.

@codeMinter
Copy link
Contributor

@sushilshinde

@Oanh-and-only-Oanh
Copy link

"countryname/flag" is out of scope of now.
FYI @codeMinter @nithyaasworld

@nithyaasworld
Copy link
Collaborator

Please find the testing observations here #3427 (comment)

@nithyaasworld nithyaasworld added the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Oct 31, 2019
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Nov 1, 2019
@codeMinter
Copy link
Contributor

@nithyaasworld this is on test and beta, please help test.

@codeMinter
Copy link
Contributor

@nithyaasworld this is on beta, please help test.

@Oanh-and-only-Oanh
Copy link

@codeMinter @nithyaasworld, the sorting for username works in beta. question I have is if username starts with a number or special character, how does it sort?
See below.
image

@codeMinter
Copy link
Contributor

codeMinter commented Nov 19, 2019

@Oanh-and-only-Oanh it is alpha sort as discussed earlier. If I am not wrong, alpha sort works on ASCII code.

@nithyaasworld
Copy link
Collaborator

Verified in Production.

Note: "countryname/flag" is out of scope for now. A new ticket has to be logged if we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants