Skip to content

Zurich filter not getting applied periodically #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtwomey opened this issue Sep 25, 2019 · 39 comments
Closed

Zurich filter not getting applied periodically #3331

mtwomey opened this issue Sep 25, 2019 · 39 comments
Assignees
@codeMinter
Labels
Challenge Listing F2F hot-fix P0 Critical (resolve within 4 hours) QA Pass in PROD Passed verification on Production Zurich

Comments

@mtwomey
Copy link
Contributor

mtwomey commented Sep 25, 2019

See video here:

https://youtu.be/f75qP2ihAzE
@sushilshinde
Copy link
Collaborator

@skyhit metadata for the private community is wrong, a filter needs to consider the context/subcommunity filter.

@sushilshinde sushilshinde added the P1 Urgent (resolve within 24 hours) label Sep 26, 2019
@sushilshinde
Copy link
Collaborator

sushilshinde commented Sep 26, 2019 •
edited
Loading

Steps to reproduce:

  1. Login with dan_developer / dantopcoder123 on https://community-app.topcoder-dev.com/
  2. Go https://community-app.topcoder-dev.com/__community__/zurich
  3. Click on the Challenges link in the top menu
  4. Wait for challenges to load
  5. Metadata on the right-hand side is wrong, sometimes it gets refreshed but it is inconsistent

Zurich Community Challenges 2019-09-26 13-49-23

Fix required

Add group Id to every listing call from the private community context

Endpoint - https://api.topcoder-dev.com/v4/challenges

Filter - https://github.com/appirio-tech/ap-challenge-microservice/blob/42934543c34be05a7f8746462efe44e051e6ad73/swagger.yaml#L100

Use these branches for PR :

  1. https://github.com/topcoder-platform/community-app/tree/hot-fix
  2. https://github.com/topcoder-platform/topcoder-react-lib/tree/hot-fix

As this is P0, please submit in 12 hours

@sushilshinde sushilshinde changed the title Zurich filter not getting applied periodically [$40]Zurich filter not getting applied periodically Sep 26, 2019
@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@crazyk07
Copy link

[500]: Challenge for the updated issue 3331 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

2 similar comments
@crazyk07
Copy link

[500]: Challenge for the updated issue 3331 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

[500]: Challenge for the updated issue 3331 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30103372 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30103372 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@anonymousjaggu anonymousjaggu self-assigned this Sep 26, 2019
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30103372 has been updated - it has been assigned to anonymousjaggu.

This is an automated message for crazyk via Topcoder X

@sushilshinde sushilshinde mentioned this issue Sep 26, 2019
Closed
@anonymousjaggu
Copy link
Collaborator

The issue is There are few requests for getting the data without the group id but those request should not be made

@anonymousjaggu anonymousjaggu removed their assignment Sep 27, 2019
@sushilshinde
Copy link
Collaborator

Requirement
#3331 (comment)

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@sushilshinde sushilshinde changed the title [$40]Zurich filter not getting applied periodically [$50]Zurich filter not getting applied periodically Sep 27, 2019
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30103372 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@rashmi73 rashmi73 self-assigned this Sep 27, 2019
@mtwomey
Copy link
Contributor Author

mtwomey commented Sep 30, 2019

@r0hit-gupta Please advise if you've also started working it (if so, we'll work something out).

@codeMinter codeMinter changed the title [$50]Zurich filter not getting applied periodically Zurich filter not getting applied periodically Oct 1, 2019
@codeMinter codeMinter self-assigned this Oct 1, 2019
@codeMinter codeMinter added the F2F label Oct 1, 2019
@codeMinter
Copy link
Contributor

Challenge launched here for the same
https://www.topcoder.com/challenges/30103753

codeMinter added a commit that referenced this issue Oct 2, 2019
@codeMinter
Fix for issue #3331
6224401
codeMinter added a commit that referenced this issue Oct 2, 2019
@codeMinter
Merge pull request #3354 from topcoder-platform/issue_3331
50e86ef 
Fix for issue #3331
@codeMinter
Copy link
Contributor

@nithyaasworld this is on DEV, can you please validate and confirm? Thanks

codeMinter added a commit that referenced this issue Oct 2, 2019
@codeMinter
changes for issue #3331
a0c773a
mtwomey added a commit that referenced this issue Oct 2, 2019
@mtwomey
Merge pull request #3355 from topcoder-platform/issue_3331
4364547 
changes for issue #3331
@nithyaasworld
Copy link
Collaborator

@codeMinter I am looking at this. So far its good. I will check further and confirm shortly.

@nithyaasworld
Copy link
Collaborator

nithyaasworld commented Oct 3, 2019 •
edited
Loading

The fix looks good to me

@nithyaasworld
Copy link
Collaborator

@codeMinter

@lakshmiathreya
Copy link

@nithyaasworld pls elaborate on your verification ... include screenshots ...

@nithyaasworld
Copy link
Collaborator

  1. Navigated to https://community-app.topcoder-dev.com/__community__/zurich being logged in as dan_developer
  2. Clicked on Challenges link. It navigated to the URL https://community-app.topcoder-dev.com/__community__/zurich/challenges?communityId=zurich
  3. removed the ?communityId=zurich from the end of the above url and pressed enter. It again navigated back to the URL https://community-app.topcoder-dev.com/__community__/zurich/challenges?communityId=zurich

When the URL is with ?communityId=zurich, it displays only the Zurich challenges

image

It always navigates to ?communityId=zurich, when I access https://community-app.topcoder-dev.com/__community__/zurich/challenges

Also tested on Beta Environment

However, it still lists Topcoder challenges in the 'Open for Review' filter. A new issue will be raised to address this.

image

@sushilshinde sushilshinde mentioned this issue Oct 3, 2019
Closed
@lakshmiathreya
Copy link

@Nithya for the Zurich filter issue - could you reference the new Issue here - for the 'Open for Review' showing other Challenges?

@lakshmiathreya
Copy link

New Issue opened for the 'Open for Review' showing other Challenges issue - 3362.

@sushilshinde sushilshinde mentioned this issue Oct 3, 2019
Merged
@lakshmiathreya lakshmiathreya added QA Pass in PROD Passed verification on Production and removed Ready for Prod QA labels Oct 4, 2019
@lakshmiathreya
Copy link

Verified that the Zurich filter is applied correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeMinter codeMinter

Labels
Challenge Listing F2F hot-fix P0 Critical (resolve within 4 hours) QA Pass in PROD Passed verification on Production Zurich
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests