Skip to content

[$50]Fix lint issues on "qa-accessibility-fix-lint" branch #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Jul 22, 2019 · 7 comments
Closed

[$50]Fix lint issues on "qa-accessibility-fix-lint" branch #2985

sushilshinde opened this issue Jul 22, 2019 · 7 comments

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 22, 2019

  1. Check out https://github.com/topcoder-platform/community-app/tree/qa-accessibility-fix-lint
  2. Run
    > npm run lint
  3. Causes validation erros like
/Users/sushil/project/tc/community-app/src/shared/containers/terms-detail/index.jsx
  151:39  error  'theme.modalMsg' is missing in props validation  react/prop-types
  1. Fix all the proptype validation issues and do not change lint rules
  2. Your changes should not break any functionality, please do smoke test locally
  3. PR to qa-accessibility-fix-lint
@sushilshinde sushilshinde changed the title Fix lint issues "qa-accessibility-fix-lint" branch [$50]Fix lint issues on "qa-accessibility-fix-lint" branch Jul 22, 2019
@sushilshinde
Copy link
Collaborator Author

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 22, 2019

Contest https://www.topcoder.com/challenges/30096450 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 22, 2019

Contest https://www.topcoder.com/challenges/30096450 has been updated - the new changes has been updated for this ticket.

This is an automated message for lazybaer via Topcoder X

@Gauravseta Gauravseta self-assigned this Jul 22, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 22, 2019

Contest https://www.topcoder.com/challenges/30096450 has been updated - it has been assigned to gauravseta.

This is an automated message for lazybaer via Topcoder X

@Gauravseta
Copy link
Collaborator

@sushilshinde PR #2989

@sushilshinde
Copy link
Collaborator Author

Thanks @Gauravseta will check today

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 23, 2019

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30096450

This is an automated message for lazybaer via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants