Skip to content

[$20][MSFT-264] Keyboard access tab operational missing #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 17, 2019 · 14 comments
Closed

[$20][MSFT-264] Keyboard access tab operational missing #2911

veshu opened this issue Jul 17, 2019 · 14 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to the detail page 'https://www.topcoder.com/challenges/30095347?tab=details'
  2. Find 'ABOUT US' in footer of the page (use virtual key to check)
  3. Use tab to navigate from virtual keyboard
  4. Observe the tab between instagram icon and support button are missing
  5. tab after instagram icon hit enter no action perform then next tab support button popup.

Expected Result
Every navigate tab from keyboard must be perform some action

Actual Result
Missing tab action while navigate via keyboard

Device: Desktop/Labtop
Operating System: Windows
Browser: Chrome

WCAG Category: 2. Operable
WCAG Level: A
WCAG Success Criterion: 2.1.1 Keyboard
Screen Reader Used:
Accessibility Audit Tool used:

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=8ab28edc%2Dd11f%2D4bb3%2Db9cf%2Da743b86a634f&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2Fkmurti%2FAccessibility%2F9

@veshu veshu changed the title [MSFT-264] Keyboard access tab operational missing [$20][MSFT-264] Keyboard access tab operational missing Jul 18, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096153 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096153 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@asadath1395
Copy link

asadath1395 commented Jul 22, 2019

@veshu This is happening because of an iframe created at src/client/index.jsx in authenticate function. There is also a TODO in that which says TODO: The iframe injected into the page by this call turns out to be visible as a tiny nob (~3x3 px). It has html ID `tc-accounts-iframe (as specified in this call). We should hide it by adding the proper side in our stylesheet, or to figure out, why it is not hidden by default. What is it used for?

asadath1395 added a commit to asadath1395/community-app that referenced this issue Jul 22, 2019
@asadath1395 asadath1395 self-assigned this Jul 22, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 22, 2019

Contest https://www.topcoder.com/challenges/30096153 has been updated - it has been assigned to sadathanwar17.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2019

Contest https://www.topcoder.com/challenges/30096715 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@jmgasper jmgasper assigned asadath1395 and unassigned asadath1395 Jul 24, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2019

Contest https://www.topcoder.com/challenges/30096715 has been updated - it has been assigned to sadathanwar17.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2019

Contest https://www.topcoder.com/challenges/30096715 has been updated - it has been assigned to sadathanwar17.

This is an automated message for lazybaer via Topcoder X

@Oanh-and-only-Oanh
Copy link

@asadath1395, are you still working on this or is it ready for code review?

@sadathanwar17
Copy link

Its ready for review

@veshu
Copy link
Contributor Author

veshu commented Jul 25, 2019

@asadath1395 Please reference the PR.

sushilshinde added a commit that referenced this issue Jul 28, 2019
Fix #2911 [MSFT-264] Keyboard access tab operational missing
@drasticdpk
Copy link
Collaborator

Operating System: Windows
Browser: Chrome
URL : https://test-community-app.topcoder-dev.com/challenges/30055275

@crazyk07
Copy link

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

@ajefts
Copy link
Member

ajefts commented Jul 30, 2019

Verified in prod.

@ajefts ajefts added the QA Pass in PROD Passed verification on Production label Jul 30, 2019
@crazyk07 crazyk07 added tcx_Paid and removed Accessibility QA Pass in PROD Passed verification on Production Ready for Prod QA labels Jul 30, 2019
@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30096715

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests