[$140] SSF: Results are loaded only after waiting for more than 40 seconds, when Development filter alone is chosen.

[nithyaasworld]

Prerequisite: User is logged in

1. Go to https://beta-community-app.topcoder.com/challenges
2. Turn off the Design and DataScience filter
3. Observe

Actual:
It takes more than 45 seconds, to load the results. This also happen when switching between the options present in the right panel, with Dev Filter alone turned on.

Expected:
It should not take such long time to load the results.

Video: will be attached shortly.

[nithyaasworld]

Video:
load time when dev alone is selected.zip

[sushilshinde]

@nithyaasworld is this new?

[nithyaasworld]

Yes @sushilshinde , It seems so!

[nithyaasworld]

This issue happens for the following combination of filters too:

[ThomasKranitsas]

@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors open for pickup

PR on ’ssf-merged-to-new-develop’ branch

[ThomasKranitsas]

[500]: Challenge for the updated issue 2695 is creating, rescheduling this event

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30094893 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30094893 has been updated - it has been assigned to gurmeetb.

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30094893 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30094893 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors prize increased on this one! Go for it!

[codeMinter]

FYI - the issue is when we do this, it hits backend to fetch approx 5000 challenges, we need to fix logic so it hits backend only upto allChallenges count which is just 600 approx.

@ThomasKranitsas sorry I couldn't put much time so opened it, but above analysis will help someone who picks next.

[nithyaasworld]

@sushilshinde @ThomasKranitsas Can we please merge this PR if ready and deploy to beta for testing? As every request to fetch_matching_results takes more than 45 seconds, its getting hard for me to verify the "Ready for QA" tickets.

Thanks.

Edit: Added "tcx_ReadyForReview" label based on the last comment by @gets0ul

[sushilshinde]

@ThomasKranitsas please review the submission

[ThomasKranitsas]

The implementation is not correct. What you're doing is:

• Load the first set of challenges
• Load every other set recursively and show everything at once

Sorry if my explanation wasn't clear enough. What I mean in my previous post is, we need to load and display all pages one by one.

I'm assuming the best way to do that is to move the recursion to the frontend.

The flow should be:

• Load and show the first set of challenges
• Load and show the next set of challenges until there are no more challenges.

You need to show the results from each page right after you get the API response. We don't want to wait until everything is loaded.

[gets0ul]

we need to load and display all pages one by one.

You need to show the results from each page right after you get the API response.

This is exactly what the current develop tree of topcoder-react-lib is doing right now, it loads and displays page one by one.

No need for a fix. Just revert the changes in src/actions/challenge-listing.js from this commit topcoder-platform/topcoder-react-lib@f02ed92#diff-8cf4059b48130a5066e66e4a473bb4a6

The flow should be:

Load and show the first set of challenges
Load and show the next set of challenges until there are no more challenges.

That's what I did with my submission while still keeping the changes from said commit above.
Have you test it? The long loading time is gone.

[gets0ul]

As the issue is urgent, you can unassign me for now so maybe others can jump in with a more fitted solution.
Thank you.

[ThomasKranitsas]

I just tested. Seems to be working

[ThomasKranitsas]

@sushilshinde can you also test on your end just to be sure?

[sushilshinde]

ok I'll

[nithyaasworld]

@sushilshinde @ThomasKranitsas @gets0ul

Issues stated here and here still exists. Can you please check?

[sushilshinde]

@gets0ul please refer to the code https://github.com/topcoder-platform/community-app/tree/server_side_filtering

Let us know if you can submit the fix today

[gets0ul]

@sushilshinde I am not sure if Ifollow. Did you mean I should make changes to server_side_filtering branch instead of ssf-merged-to-new-develop?

@nithyaasworld
Did you you do your check on https://beta-community-app.topcoder.com/challenges?
I see that it still has the problem.
Are you sure that it runs with updated build with my fix?

[sushilshinde]

@gets0ul no, the same thing was working on server_side_filtering branch when @nithyaasworld tester, but after merge with the release branch this issues started popping up.

[gets0ul]

@sushilshinde I submit the PR to develop branch of topcoder-react-lib, so I didn't include the dist build in it. You need to build by yourrself.
Have you run the build before publish the topcoder-react-lib npm run build?
Thanks.

[ThomasKranitsas]

Closing this one. I'll take care of the remaining fixes.

[ThomasKranitsas]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30094893

This is an automated message for thomaskranitsas via Topcoder X

[lakshmiathreya]

@ThomasKranitsas @Oanh-and-only-Oanh @kkartunov - Listing latency issue seems resolved. Pls confirm if this fix is moving to Prod today? If so - we need to review the need for regression testing based on the following:-

1. Are there other changes going to Prod alongwith this change?
2. What were the changes made to improve performance - any possible functional impact?