Skip to content

Show verification badge in the /settings/profile#skills page too #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nithyaasworld opened this issue Jun 19, 2019 · 8 comments
Closed

Show verification badge in the /settings/profile#skills page too #2642

nithyaasworld opened this issue Jun 19, 2019 · 8 comments
Assignees
@codeMinter
Labels
P4 Low (resolve within 2 weeks) QA Pass

Comments

@nithyaasworld
Copy link
Collaborator

Actual:
Currently Verified Skills badge is displayed only here: https://www.topcoder.com/members/nithyaasworld

Expected:
Verified Skills badge should also appear in this page too: https://www.topcoder.com/settings/profile#skills
@nithyaasworld nithyaasworld added the P4 Low (resolve within 2 weeks) label Jun 19, 2019
@codeMinter codeMinter self-assigned this Jun 19, 2019
codeMinter added a commit that referenced this issue Jun 20, 2019
@codeMinter
Fix for issue #2642
0a0604f
sushilshinde added a commit that referenced this issue Jun 22, 2019
@sushilshinde
Merge pull request #2650 from topcoder-platform/issue_2642
0ac8334 
Fix for issue #2642
@codeMinter
Copy link
Contributor

@nithyaasworld this was deployed here - https://beta-community-app.topcoder.com/settings/profile#skills - can you help validate?

@nithyaasworld
Copy link
Collaborator Author

@gurmeetb It seems like the fix is no longer available in beta environment. Can you please re-deploy and let me know in slack?

Sorry that I missed to notice your above message.

@codeMinter
Copy link
Contributor

@nithyaasworld will work to get it back on env where you can test this, thanks for flagging.

@codeMinter
Copy link
Contributor

codeMinter commented Jun 27, 2019 •
edited
Loading

@nithyaasworld this is deployed to https://beta-community-app.topcoder.com/settings/profile#skills

Can you please help test this? Thanks

@nithyaasworld
Copy link
Collaborator Author

nithyaasworld commented Jun 27, 2019 •
edited
Loading

Thanks @gurmeetb But hovering on the badge, shows remove option along with the tooltip. Can we show only tooltip when hovering on the badge and not the remove option?

image

codeMinter added a commit that referenced this issue Jun 27, 2019
@codeMinter
Merge pull request #2685 from topcoder-platform/issue_2642
982c191 
incorporate feedback for #2642
@codeMinter
Copy link
Contributor

@nithyaasworld done, kindly validate.

@nithyaasworld
Copy link
Collaborator Author

Thanks @gurmeetb Verified.

@codeMinter codeMinter mentioned this issue Jun 27, 2019
Merged
sushilshinde added a commit that referenced this issue Jun 28, 2019
@sushilshinde
Merge pull request #2683 from topcoder-platform/issue_2642
9da908f 
Fix for issue #2642
@codeMinter codeMinter mentioned this issue Jun 28, 2019
Merged
sushilshinde added a commit that referenced this issue Jun 28, 2019
@sushilshinde
Merge pull request #2687 from topcoder-platform/develop-from-master-2…
09f42fb 
…3may

Deploy issue #2642 on PROD
@codeMinter
Copy link
Contributor

@Oanh-and-only-Oanh @nithyaasworld This is on PROD now, https://www.topcoder.com/settings/profile/#skills - kindly help verify and close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeMinter codeMinter

Labels
P4 Low (resolve within 2 weeks) QA Pass
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nithyaasworld @codeMinter @Oanh-and-only-Oanh